Adding ability to deploy helm chart to a namespace. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow for watching on specific namespaces, not clusterwide. Signed-off-by: Houston Putman <hputman@apple.com>
bsankara
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: Resolves #118 Resolves #119
Describe your changes
This PR allows for the solr operator to be deployed to a specific namespace using the helm chart.
This can be done with
helm install --namespace <ex>.The ability to watch specific namespaces has also been added via the
watchNamespaceshelm variable, as well as the--watch-namespacesoption to the solr operator program.If neither is provided, then the operator will watch the entire kubernetes cluster (all namespaces).
There are also now parameters for creating RBAC/ServiceAccounts.
Testing performed
I have installed the operator with many different configurations manually using the helm chart.