[MINOR] Updated readme and go example code #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @grundprinzip |
grundprinzip
reviewed
Jun 5, 2023
| ``` | ||
| git clone https://github.com/apache/spark-connect-go.git | ||
| git submodule init --depth 1 | ||
| git submodule update --init --recursive |
There was a problem hiding this comment.
I think the --depth 1 might still be good to avoid pulling all of Spark.
HyukjinKwon
changed the title
grundprinzip
approved these changes
Jun 5, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
readme.mdto includebufdependencymakecalls ( thanks @grundprinzip for that tip )cmd/spark-connect-example-spark-session/main.goas its missingsc:Why are the changes needed?
The changes are required so users can run the spark-connect-go example
Does this PR introduce any user-facing change?
No user-facing changes, just fixed minor doc and bug issues.
How was this patch tested?
Ran the instructions per the
readme.md