Skip to content

Commit 0be8b45

Browse files
berngppwendell
authored andcommitted
SPARK-1806: Upgrade Mesos dependency to 0.18.1
Enabled Mesos (0.18.1) dependency with shaded protobuf Why is this needed? Avoids any protobuf version collision between Mesos and any other dependency in Spark e.g. Hadoop HDFS 2.2+ or 1.0.4. Ticket: https://issues.apache.org/jira/browse/SPARK-1806 * Should close https://issues.apache.org/jira/browse/SPARK-1433 Author berngp Author: Bernardo Gomez Palacio <bernardo.gomezpalacio@gmail.com> Closes #741 from berngp/feature/SPARK-1806 and squashes the following commits: 5d70646 [Bernardo Gomez Palacio] SPARK-1806: Upgrade Mesos dependency to 0.18.1
1 parent c88adbb commit 0be8b45

File tree

5 files changed

+14
-5
lines changed

5 files changed

+14
-5
lines changed

core/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@
140140
<dependency>
141141
<groupId>org.apache.mesos</groupId>
142142
<artifactId>mesos</artifactId>
143+
<classifier>${mesos.classifier}</classifier>
143144
</dependency>
144145
<dependency>
145146
<groupId>io.netty</groupId>
@@ -322,7 +323,7 @@
322323
</configuration>
323324
</plugin>
324325
</plugins>
325-
326+
326327
<resources>
327328
<resource>
328329
<directory>src/main/resources</directory>

core/src/main/scala/org/apache/spark/executor/MesosExecutorBackend.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ package org.apache.spark.executor
1919

2020
import java.nio.ByteBuffer
2121

22-
import com.google.protobuf.ByteString
22+
import org.apache.mesos.protobuf.ByteString
2323
import org.apache.mesos.{Executor => MesosExecutor, ExecutorDriver, MesosExecutorDriver, MesosNativeLibrary}
2424
import org.apache.mesos.Protos.{TaskStatus => MesosTaskStatus, _}
2525

core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import java.util.Collections
2424
import scala.collection.JavaConversions._
2525
import scala.collection.mutable.{ArrayBuffer, HashMap, HashSet}
2626

27-
import com.google.protobuf.ByteString
27+
import org.apache.mesos.protobuf.ByteString
2828
import org.apache.mesos.{Scheduler => MScheduler}
2929
import org.apache.mesos._
3030
import org.apache.mesos.Protos.{TaskInfo => MesosTaskInfo, TaskState => MesosTaskState, _}

pom.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@
113113

114114
<scala.version>2.10.4</scala.version>
115115
<scala.binary.version>2.10</scala.binary.version>
116-
<mesos.version>0.13.0</mesos.version>
116+
<mesos.version>0.18.1</mesos.version>
117+
<mesos.classifier>shaded-protobuf</mesos.classifier>
117118
<akka.group>org.spark-project.akka</akka.group>
118119
<akka.version>2.2.3-shaded-protobuf</akka.version>
119120
<slf4j.version>1.7.5</slf4j.version>
@@ -349,6 +350,13 @@
349350
<groupId>org.apache.mesos</groupId>
350351
<artifactId>mesos</artifactId>
351352
<version>${mesos.version}</version>
353+
<classifier>${mesos.classifier}</classifier>
354+
<exclusions>
355+
<exclusion>
356+
<groupId>com.google.protobuf</groupId>
357+
<artifactId>protobuf-java</artifactId>
358+
</exclusion>
359+
</exclusions>
352360
</dependency>
353361
<dependency>
354362
<groupId>commons-net</groupId>

project/SparkBuild.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ object SparkBuild extends Build {
343343
"org.spark-project.akka" %% "akka-testkit" % akkaVersion % "test",
344344
"org.json4s" %% "json4s-jackson" % "3.2.6" excludeAll(excludeScalap),
345345
"colt" % "colt" % "1.2.0",
346-
"org.apache.mesos" % "mesos" % "0.13.0",
346+
"org.apache.mesos" % "mesos" % "0.18.1" classifier("shaded-protobuf") exclude("com.google.protobuf", "protobuf-java"),
347347
"commons-net" % "commons-net" % "2.2",
348348
"net.java.dev.jets3t" % "jets3t" % jets3tVersion excludeAll(excludeCommonsLogging),
349349
"org.apache.derby" % "derby" % "10.4.2.0" % "test",

0 commit comments

Comments
 (0)