SPARK-12998 [SQL]. Enable OrcRelation when connecting via spark thrif… #10938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this actually have anything to do the thrift server, or simply just any table when loading from the meatstore? |
|
Maybe we might have to correct the title just like the others (this is described in https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark). Also, the title looks truncated. |
|
Test build #57632 has finished for PR 10938 at commit
|
|
Major chunks of this PR is already in trunk after https://github.com/apache/spark/pull/11891/files so this PR is not necessary anymore (unless I missed something). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user connects via spark-thrift server to execute SQL, it does not enable PPD with ORC. It ends up creating MetastoreRelation which does not have ORC PPD. Purpose of this JIRA is to convert MetastoreRelation to OrcRelation in HiveMetastoreCatalog, so that users can benefit from PPD even when connecting to spark-thrift server.
For e.g, Query "select count(1) from tpch_flat_orc_1000.lineitem where l_shipdate = '1990-04-18'" which is fired against spark-thrift-server or sqlContext would end up using "OrcRelation" to make use of PPD instead of MetastoreRelation.