[SPARK-13355] [MLLIB] replace GraphImpl.fromExistingRDDs by Graph.apply #11226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphImpl.fromExistingRDDs
expects preprocessed vertex RDD as input. We call it in LDA without validating this requirement. So it might introduce errors. Replacing it byGraph.apply
would be safer and more proper because it is a public API. The tests still pass. So maybe it is safe to usefromExistingRDDs
here (though it doesn't seem so based on the implementation) or the test cases are special. @jkbradley @ankurdave