Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-15028][SQL] Remove HiveSessionState.setDefaultOverrideConfs #12806

Closed
wants to merge 2 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Apr 30, 2016

What changes were proposed in this pull request?

This patch removes some code that are no longer relevant -- mainly HiveSessionState.setDefaultOverrideConfs.

How was this patch tested?

N/A

@rxin
Copy link
Contributor Author

rxin commented Apr 30, 2016

cc @yhuai

@@ -44,8 +44,6 @@ private[hive] class HiveSessionState(sparkSession: SparkSession)
*/
lazy val metadataHive: HiveClient = sharedState.metadataHive.newSession()

setDefaultOverrideConfs()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove this method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@yhuai
Copy link
Contributor

yhuai commented Apr 30, 2016

lgtm

@SparkQA
Copy link

SparkQA commented Apr 30, 2016

Test build #57413 has finished for PR 12806 at commit 0f96f1a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • implicit class DebugSQLContext(sparkSession: SparkSession)

@yhuai
Copy link
Contributor

yhuai commented Apr 30, 2016

Merging to master.

@asfgit asfgit closed this in 8dc3987 Apr 30, 2016
@SparkQA
Copy link

SparkQA commented Apr 30, 2016

Test build #57418 has finished for PR 12806 at commit 49a1305.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants