[SPARK-16558][Examples][MLlib] examples/mllib/LDAExample should use MLVector instead of MLlib Vector #14212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #62358 has finished for PR 14212 at commit
|
|
Test build #62696 has finished for PR 14212 at commit
|
|
The fix LGTM - I'm in two minds about whether this example is "good" (illustrating using both And we already have a |
|
@MLnick They serve different purpose. This one is for users who have built their tools upon it. The |
|
LGTM, merged into master/branch-2.0. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Aug 2, 2016
…LVector instead of MLlib Vector ## What changes were proposed in this pull request? mllib.LDAExample uses ML pipeline and MLlib LDA algorithm. The former transforms original data into MLVector format, while the latter uses MLlibVector format. ## How was this patch tested? Test manually. Author: Xusen Yin <yinxusen@gmail.com> Closes #14212 from yinxusen/SPARK-16558. (cherry picked from commit dd8514f) Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
mllib.LDAExample uses ML pipeline and MLlib LDA algorithm. The former transforms original data into MLVector format, while the latter uses MLlibVector format.
How was this patch tested?
Test manually.