[SPARK-16663][SQL] desc table should be consistent between data source and hive serde tables #14302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yhuai @liancheng |
|
Test build #62679 has finished for PR 14302 at commit
|
|
Test build #62699 has finished for PR 14302 at commit
|
|
Test build #62709 has finished for PR 14302 at commit
|
| append(buffer, s"# ${output.head.name}", "", "") | ||
| partCols.foreach(col => append(buffer, col, "", "")) | ||
| append(buffer, s"# ${output.head.name}", output(1).name, output(2).name) | ||
| val partCols = partColNames.map(n => schema.get.find(_.name == n).get) |
There was a problem hiding this comment.
What do you think about this?
val s = schema.get
s.fieldNames.intersect(partColNames).map(s.apply)
There was a problem hiding this comment.
I'd rewrite the whole if as following:
for (s <- schema if partColNames.nonEmpty) {
append(buffer, "# Partition Information", "", "")
append(buffer, s"# ${output.head.name}", output(1).name, output(2).name)
describeSchema(StructType(partColNames.map(s(_))))
}
|
Test build #62859 has finished for PR 14302 at commit
|
|
Test build #62865 has finished for PR 14302 at commit
|
|
LGTM, merging to master. |
|
@cloud-fan To backport #14531, we need to backport this. Do you want me to do it? |
asfgit
pushed a commit
that referenced
this pull request
Sep 3, 2016
…e and hive serde tables Currently there are 2 inconsistence: 1. for data source table, we only print partition names, for hive table, we also print partition schema. After this PR, we will always print schema 2. if column doesn't have comment, data source table will print empty string, hive table will print null. After this PR, we will always print null new test in `HiveDDLSuite` Author: Wenchen Fan <wenchen@databricks.com> Closes #14302 from cloud-fan/minor3. (cherry picked from commit a2abb58) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
backported to 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently there are 2 inconsistence:
How was this patch tested?
new test in
HiveDDLSuite