[SPARK-16690][TEST] rename SQLTestUtils.withTempTable to withTempView #14318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, pending jenkins |
|
Test build #62729 has finished for PR 14318 at commit
|
|
Let's create a jira :) |
cloud-fan
changed the title
|
Merging in master. |
|
I'm going to cherry pick this into branch-2.0 to avoid conflicts in bug fixes. |
asfgit
pushed a commit
that referenced
this pull request
Jul 23, 2016
after #12945, we renamed the `registerTempTable` to `createTempView`, as we do create a view actually. This PR renames `SQLTestUtils.withTempTable` to reflect this change. N/A Author: Wenchen Fan <wenchen@databricks.com> Closes #14318 from cloud-fan/minor4. (cherry picked from commit 86c2752) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
after #12945, we renamed the
registerTempTabletocreateTempView, as we do create a view actually. This PR renamesSQLTestUtils.withTempTableto reflect this change.How was this patch tested?
N/A