[SPARK-16730][SQL] Implement function aliases for type casts #14362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,24 +200,6 @@ class TypeCoercionSuite extends PlanTest { | |||
| widenTest(ArrayType(IntegerType), StructType(Seq()), None) | |||
| } | |||
|
|
|||
| private def ruleTest(rule: Rule[LogicalPlan], initial: Expression, transformed: Expression) { | |||
There was a problem hiding this comment.
I moved this into PlanTest
|
@cloud-fan and @hvanhovell can you take a look? |
| case u: UnresolvedFunction | ||
| if u.name.database.isEmpty && u.children.size == 1 && !u.isDistinct => | ||
| u.name.funcName.toLowerCase match { | ||
| case "boolean" => Cast(u.children.head, BooleanType) |
There was a problem hiding this comment.
can we use FunctionRegister to handle these?
There was a problem hiding this comment.
do you mean putting in FunctionRegistry?
There was a problem hiding this comment.
yup, but not sure if it can work
There was a problem hiding this comment.
+1 for this. I think you can make it work. Implement a method that creates the same as FunctionRegistry.expression[T <: Expression](name: String) method, e.g.:
def cast(name: String, dt: DataType): (String, (ExpressionInfo, FunctionBuilder)) = {
val info = new ExpressionInfo(classOf[Cast].getName, name)
name -> (info, Cast(_, dt))
}and use that method to register these casts...
There was a problem hiding this comment.
That was in #14364
|
Test build #62869 has finished for PR 14362 at commit
|
|
Closing this one in favor of #14364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark 1.x supports using the Hive type name as function names for doing casts, e.g.
The above query would work in Spark 1.x because Spark 1.x fail back to Hive for unimplemented functions, and break in Spark 2.0 because the fall back was removed.
This patch implements function aliases using an analyzer rule for the following cast functions:
How was this patch tested?
Added unit tests for SubstituteFunctionAliases as well as end-to-end tests for SQLCompatibilityFunctionSuite.