Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2495][MLLIB] remove private[mllib] from linear models' constructors #1492

Closed
wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Jul 19, 2014

This is part of SPARK-2495 to allow users construct linear models manually.

@SparkQA
Copy link

SparkQA commented Jul 19, 2014

QA tests have started for PR 1492. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16845/consoleFull

@mengxr
Copy link
Contributor Author

mengxr commented Jul 19, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 19, 2014

QA tests have started for PR 1492. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16850/consoleFull

@rxin
Copy link
Contributor

rxin commented Jul 20, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 20, 2014

QA tests have started for PR 1492. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16868/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 20, 2014

QA results for PR 1492:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds the following public classes (experimental):
class LogisticRegressionModel (
class SVMModel (
class LassoModel (
class LinearRegressionModel (
class RidgeRegressionModel (

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16868/consoleFull

@rxin
Copy link
Contributor

rxin commented Jul 20, 2014

Merging in master.

@asfgit asfgit closed this in 1b10b81 Jul 20, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
…ctors

This is part of SPARK-2495 to allow users construct linear models manually.

Author: Xiangrui Meng <meng@databricks.com>

Closes apache#1492 from mengxr/public-constructor and squashes the following commits:

a48b766 [Xiangrui Meng] remove private[mllib] from linear models' constructors
kazuyukitanimura added a commit to kazuyukitanimura/spark that referenced this pull request Aug 16, 2022
`ReplaceNullWithFalseInPredicateEndToEndSuite` was not expecting to see `AdaptiveSparkPlanExec`.
I plan to submit this fix in the upstream so that we don't have to worry about using different version of spark to use with Boson in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants