-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-17391] [TEST] [2.0] Fix Two Test Failures After Backport #14951
Conversation
Test build #64907 has finished for PR 14951 at commit
|
@@ -77,7 +77,7 @@ class HiveExplainSuite extends QueryTest with SQLTestUtils with TestHiveSingleto | |||
"src") | |||
} | |||
|
|||
test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan") { | |||
test("SPARK-17230: The EXPLAIN output of CTAS only shows the analyzed plan") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did we break this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we backporting this PR: #14797 , it breaks the existing test case. It does not correctly work in the master branch. If we do not want to optimize the query of CTAS, we should see SubqueryAlias
. Thus, the test case did not fail in the master branch.
thanks for fixing it! Sorry this is my bad, I should be more careful when backporting DDL related bug fixes to 2.0, as the code of master and 2.0 differ a lot now. |
Yeah, it is a little bit painful when we backport the PRs. When I backported |
### What changes were proposed in this pull request? In the latest branch 2.0, we have two test case failure due to backport. - test("ALTER VIEW AS should keep the previous table properties, comment, create_time, etc.") - test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan") ### How was this patch tested? N/A Author: gatorsmile <gatorsmile@gmail.com> Closes #14951 from gatorsmile/fixTestFailure.
thanks, merging to 2.0! |
Since it is merged, I close it now. Thanks! |
What changes were proposed in this pull request?
In the latest branch 2.0, we have two test case failure due to backport.
How was this patch tested?
N/A