Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-17391] [TEST] [2.0] Fix Two Test Failures After Backport #14951

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

What changes were proposed in this pull request?

In the latest branch 2.0, we have two test case failure due to backport.

  • test("ALTER VIEW AS should keep the previous table properties, comment, create_time, etc.")
  • test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan")

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

@gatorsmile gatorsmile changed the title [SPARK-17391] [TEST] Fix Two Test Failures After Backport [SPARK-17391] [TEST] [2.0] Fix Two Test Failures After Backport Sep 3, 2016
@SparkQA
Copy link

SparkQA commented Sep 3, 2016

Test build #64907 has finished for PR 14951 at commit 2f02bed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -77,7 +77,7 @@ class HiveExplainSuite extends QueryTest with SQLTestUtils with TestHiveSingleto
"src")
}

test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan") {
test("SPARK-17230: The EXPLAIN output of CTAS only shows the analyzed plan") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did we break this test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we backporting this PR: #14797 , it breaks the existing test case. It does not correctly work in the master branch. If we do not want to optimize the query of CTAS, we should see SubqueryAlias. Thus, the test case did not fail in the master branch.

@cloud-fan
Copy link
Contributor

thanks for fixing it! Sorry this is my bad, I should be more careful when backporting DDL related bug fixes to 2.0, as the code of master and 2.0 differ a lot now.

@gatorsmile
Copy link
Member Author

Yeah, it is a little bit painful when we backport the PRs. When I backported CREATE TABLE LIKE, I found I already forgot how CREATE TABLE works in Spark 2.0. : )

asfgit pushed a commit that referenced this pull request Sep 5, 2016
### What changes were proposed in this pull request?
In the latest branch 2.0, we have two test case failure due to backport.

- test("ALTER VIEW AS should keep the previous table properties, comment, create_time, etc.")
- test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan")

### How was this patch tested?
N/A

Author: gatorsmile <gatorsmile@gmail.com>

Closes #14951 from gatorsmile/fixTestFailure.
@cloud-fan
Copy link
Contributor

thanks, merging to 2.0!

@gatorsmile
Copy link
Member Author

gatorsmile commented Sep 5, 2016

Since it is merged, I close it now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants