[WIP] [SPARK-17421] Don't use -XX:MaxPermSize option when Java version >= 8 #14986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
If you're just solving the warning, I don't think this extra complexity is worthwhile. Java 7 support will go away soon anyway. |
|
Make sense. I will close this PR and just add a clarification to the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modifies the
build/mvnandbuild/sbt-launch-lib.bashscripts so that they check the Java version and omit the-XX:MaxPermSize=512Moption for Java versions >= 8.How was this patch tested?
Ran the build on Linux and Mac with Java 7 and 8, from
build/mvnanddev/run-tests. Also tested Java 8 withJAVA_7_HOMEpointing to a Java 7 installation.Currently,
dev/run-testshas a few remaining instances of the MaxPermSize warning, apparently due to another code path to spawning a JVM. Keeping this PR as a WIP until the output ofdev/run-testsis completely clean.