[SPARK-17650] malformed url's throw exceptions before bricking Executors #15224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rxin |
|
Should we check more in addition to just mailformed urls? |
|
Other places check malformedURIs already (since we always pass around URIs). We can check if the endpoint exists and everything, but that seems a bit heavyweight. |
|
Maybe we also need the blacklisting in case of failures? Maybe they provide a valid URL that doesn't exist, or is unreachable? |
|
cc @zsxwing for review ... |
zsxwing
requested changes
Sep 23, 2016
| } catch { | ||
| case e: MalformedURLException => | ||
| val msg = s"URI (${uri.toString}) is not a valid URL." | ||
| logError(msg) |
There was a problem hiding this comment.
nit: not need to log it since it's already be thrown.
|
@zsxwing Thanks for the review. Addressed the nit. |
|
Test build #65846 has finished for PR 15224 at commit
|
|
Test build #65854 has finished for PR 15224 at commit
|
|
Thanks. Merging to master and 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Sep 26, 2016
## What changes were proposed in this pull request? When a malformed URL was sent to Executors through `sc.addJar` and `sc.addFile`, the executors become unusable, because they constantly throw `MalformedURLException`s and can never acknowledge that the file or jar is just bad input. This PR tries to fix that problem by making sure MalformedURLs can never be submitted through `sc.addJar` and `sc.addFile`. Another solution would be to blacklist bad files and jars on Executors. Maybe fail the first time, and then ignore the second time (but print a warning message). ## How was this patch tested? Unit tests in SparkContextSuite Author: Burak Yavuz <brkyvz@gmail.com> Closes #15224 from brkyvz/SPARK-17650. (cherry picked from commit 59d87d2) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a malformed URL was sent to Executors through
sc.addJarandsc.addFile, the executors become unusable, because they constantly throwMalformedURLExceptions and can never acknowledge that the file or jar is just bad input.This PR tries to fix that problem by making sure MalformedURLs can never be submitted through
sc.addJarandsc.addFile. Another solution would be to blacklist bad files and jars on Executors. Maybe fail the first time, and then ignore the second time (but print a warning message).How was this patch tested?
Unit tests in SparkContextSuite