Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-17843][WEB UI] Indicate event logs pending for processing on h… #15991

Closed
wants to merge 1 commit into from

Conversation

vijoshi
Copy link
Contributor

@vijoshi vijoshi commented Nov 23, 2016

What changes were proposed in this pull request?

Backport PR #15410 to branch-2.0

How was this patch tested?

Existing unit tests. Screenshots for UI changes provided in PR #15410.

@vijoshi
Copy link
Contributor Author

vijoshi commented Nov 23, 2016

@tgravescs - Looking to get this change early with 2.0.x. This merges cleanly - are you ok to let this into branch-2.0?

@SparkQA
Copy link

SparkQA commented Nov 23, 2016

Test build #69061 has finished for PR 15991 at commit 6de3036.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.


{
if (lastUpdatedTime > 0) {
<p>Last updated: <span id="last-updated">{lastUpdatedTime}</span></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just going to display a Long to the user? That's not going to be very informative. What about a human time where <= 0 is mapped to "never"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the javascript on the web page translates the long to a human readable date-time value - in the viewer's (i.e. browser's) local timezone.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see —thanks. That's all I was worried about.

@vijoshi
Copy link
Contributor Author

vijoshi commented Nov 29, 2016

@tgravescs - are you ok to merge this backport to branch-2.0 ?

@tgravescs
Copy link
Contributor

The reason I hadn't pulled it back is its listed as a minor improvement and generally we only pull defects back into the maintenance releases.

@vijoshi
Copy link
Contributor Author

vijoshi commented Nov 30, 2016

@tgravescs would like to have this in 2.0 along with the other improvement that got accepted for backport (spark-18010). so would you consider allowing this into 2.0 as well?

@tgravescs
Copy link
Contributor

since its just in the history server and pretty isolated seems ok. +1

asfgit pushed a commit that referenced this pull request Nov 30, 2016
## What changes were proposed in this pull request?

Backport PR #15410 to branch-2.0

## How was this patch tested?

Existing unit tests. Screenshots for UI changes provided in PR #15410.

Author: Vinayak <vijoshi5@in.ibm.com>

Closes #15991 from vijoshi/SAAS-608.
@vijoshi vijoshi closed this Nov 30, 2016
@vijoshi vijoshi deleted the SAAS-608 branch January 24, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants