[SPARK-18949] [SQL] Add recoverPartitions API to Catalog #16356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the SQL equivalent command? MSCK? Should we match that? |
|
We have two SQL equivalent commands:
I am not good at naming. How about |
|
Test build #70416 has finished for PR 16356 at commit
|
|
Yea recoverPartitions sound a lot better. |
|
We should also add the Python API. |
|
Sure, will do. Thanks! |
gatorsmile
changed the title
|
We can laso merge this in branch-2.1. So let's do 2.1.1 as since version. |
gatorsmile
commented
Dec 20, 2016
| ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.util.sketch.CountMinSketch.toByteArray") | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.util.sketch.CountMinSketch.toByteArray"), | ||
| // [SPARK-18949] [SQL] Add repairTable API to Catalog | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.recoverPartitions") |
There was a problem hiding this comment.
When backporting this PR to 2.1.1, we might need to move this to the next section 2.1.x.
|
Test build #70422 has finished for PR 16356 at commit
|
|
LGTM pending tests. |
gatorsmile
commented
Dec 20, 2016
| @@ -258,6 +258,11 @@ def refreshTable(self, tableName): | |||
| """Invalidate and refresh all the cached metadata of the given table.""" | |||
| self._jcatalog.refreshTable(tableName) | |||
|
|
|||
| @since(2.1.1) | |||
There was a problem hiding this comment.
Will change it to 2.1. 2.1.1 causes the doc build break. If needed, I can do more investigation to see how to do it for 2.1.1
rxin
reviewed
Dec 20, 2016
| @@ -258,6 +258,11 @@ def refreshTable(self, tableName): | |||
| """Invalidate and refresh all the cached metadata of the given table.""" | |||
| self._jcatalog.refreshTable(tableName) | |||
|
|
|||
| @since(2.1) | |||
There was a problem hiding this comment.
you can do "2.1.1" as a string
|
Test build #70418 has finished for PR 16356 at commit
|
|
Test build #70426 has finished for PR 16356 at commit
|
|
Test build #70423 has finished for PR 16356 at commit
|
|
Test build #3511 has finished for PR 16356 at commit
|
|
Merging in master/branch-2.1. |
|
Can you send a pr for branch-2.1? |
|
Sure, let me do it now. |
asfgit
pushed a commit
that referenced
this pull request
Dec 21, 2016
### What changes were proposed in this pull request? This PR is to backport #16356 to Spark 2.1.1 branch. ---- Currently, we only have a SQL interface for recovering all the partitions in the directory of a table and update the catalog. `MSCK REPAIR TABLE` or `ALTER TABLE table RECOVER PARTITIONS`. (Actually, very hard for me to remember `MSCK` and have no clue what it means) After the new "Scalable Partition Handling", the table repair becomes much more important for making visible the data in the created data source partitioned table. Thus, this PR is to add it into the Catalog interface. After this PR, users can repair the table by ```Scala spark.catalog.recoverPartitions("testTable") ``` ### How was this patch tested? Modified the existing test cases. Author: gatorsmile <gatorsmile@gmail.com> Closes #16372 from gatorsmile/repairTable2.1.1.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
### What changes were proposed in this pull request?
Currently, we only have a SQL interface for recovering all the partitions in the directory of a table and update the catalog. `MSCK REPAIR TABLE` or `ALTER TABLE table RECOVER PARTITIONS`. (Actually, very hard for me to remember `MSCK` and have no clue what it means)
After the new "Scalable Partition Handling", the table repair becomes much more important for making visible the data in the created data source partitioned table.
Thus, this PR is to add it into the Catalog interface. After this PR, users can repair the table by
```Scala
spark.catalog.recoverPartitions("testTable")
```
### How was this patch tested?
Modified the existing test cases.
Author: gatorsmile <gatorsmile@gmail.com>
Closes apache#16356 from gatorsmile/repairTable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, we only have a SQL interface for recovering all the partitions in the directory of a table and update the catalog.
MSCK REPAIR TABLEorALTER TABLE table RECOVER PARTITIONS. (Actually, very hard for me to rememberMSCKand have no clue what it means)After the new "Scalable Partition Handling", the table repair becomes much more important for making visible the data in the created data source partitioned table.
Thus, this PR is to add it into the Catalog interface. After this PR, users can repair the table by
spark.catalog.recoverPartitions("testTable")How was this patch tested?
Modified the existing test cases.