Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-18958][SPARKR] R API toJSON on DataFrame #16368

Closed
wants to merge 2 commits into from

Conversation

felixcheung
Copy link
Member

@felixcheung felixcheung commented Dec 21, 2016

What changes were proposed in this pull request?

It would make it easier to integrate with other component expecting row-based JSON format.
This replaces the non-public toJSON RDD API.

How was this patch tested?

manual, unit tests

@SparkQA
Copy link

SparkQA commented Dec 21, 2016

Test build #70451 has finished for PR 16368 at commit e2031ea.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

LGTM. Thanks @felixcheung

@shivaram
Copy link
Contributor

shivaram commented Dec 23, 2016

Merging this into master, branch-2.0, branch-2.1

@shivaram
Copy link
Contributor

Hmm looks like this is merged but not reflected on github ?

@felixcheung
Copy link
Member Author

I kept getting error with the merge script - not sure if it went through. we are likely having some sync issue with github?

@felixcheung
Copy link
Member Author

felixcheung commented Dec 23, 2016

ah, it was merged to master https://git-wip-us.apache.org/repos/asf?p=spark.git

@asfgit asfgit closed this in 17579bd Dec 23, 2016
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Dec 24, 2016
## What changes were proposed in this pull request?

It would make it easier to integrate with other component expecting row-based JSON format.
This replaces the non-public toJSON RDD API.

## How was this patch tested?

manual, unit tests

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#16368 from felixcheung/rJSON.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

It would make it easier to integrate with other component expecting row-based JSON format.
This replaces the non-public toJSON RDD API.

## How was this patch tested?

manual, unit tests

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#16368 from felixcheung/rJSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants