[SPARK-19054][ML] Eliminate extra pass in NB #16453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #70792 has finished for PR 16453 at commit
|
srowen
approved these changes
Jan 3, 2017
jkbradley
reviewed
Jan 3, 2017
| val numClasses = getNumClasses(dataset) | ||
| if (isDefined(thresholds)) { | ||
| require($(thresholds).length == numClasses, this.getClass.getSimpleName + | ||
| require($(thresholds).length == numClasses, this.getClass.getSimpleName + | ||
| ".train() called with non-matching numClasses and thresholds.length." + |
There was a problem hiding this comment.
Could you please fix the indentation here?
|
LGTM except for the style nit |
|
Updated. Thanks for reviewing. |
|
Test build #70854 has finished for PR 16453 at commit
|
|
Merged to master |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Jan 9, 2017
## What changes were proposed in this pull request? eliminate unnecessary extra pass in NB's train ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes apache#16453 from zhengruifeng/nb_getNC.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? eliminate unnecessary extra pass in NB's train ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes apache#16453 from zhengruifeng/nb_getNC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
eliminate unnecessary extra pass in NB's train
How was this patch tested?
existing tests