[SPARK-19082][SQL] Make ignoreCorruptFiles work for Parquet #16474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #70903 has finished for PR 16474 at commit
|
rxin
reviewed
Jan 6, 2017
| // Reads footers in multi-threaded manner within each task | ||
| val footers = | ||
| ParquetFileReader.readAllFootersInParallel( | ||
| serializedConf.value, fakeFileStatuses.asJava, skipRowGroups).asScala | ||
| ParquetFileFormat.readParquetFootersInParallel( |
There was a problem hiding this comment.
what's happening to readAllFootersInParallel?
There was a problem hiding this comment.
We can't make it ignore corrupt files. So it successfully reads all footers or completely fails even just one footer is corrupt.
There was a problem hiding this comment.
Can we add some unit tests for readParquetFootersInParallel
rxin
reviewed
Jan 6, 2017
| partFiles: Seq[FileStatus], | ||
| ignoreCorruptFiles: Boolean): Seq[Footer] = { | ||
| val footers = partFiles.map { currentFile => | ||
| new Callable[Option[Footer]]() { |
There was a problem hiding this comment.
this seems pretty convoluted. can we jsut use parallel collections to do this?
There was a problem hiding this comment.
ok. let me try to change this to parallel collections.
viirya
force-pushed
the
fix-ignorecorrupted-parquet-files
branch
from
d6878e1
to
6b562eb
Compare
|
Test build #71053 has finished for PR 16474 at commit
|
|
Test build #71055 has finished for PR 16474 at commit
|
|
ping @rxin I do address the previous comments. Can you review again? |
cloud-fan
reviewed
Jan 12, 2017
| // E.g., vectorized Parquet reader. | ||
| readFunction(currentFile) | ||
| } catch { | ||
| case e @(_: RuntimeException | _: IOException) => |
There was a problem hiding this comment.
shall we also check the error message? or RuntimeException may catch other unexpected exceptions.
There was a problem hiding this comment.
yeah, I have this concern too in the pr description.
One problem is the error message is varying across data sources. To list all error messages here looks not a good idea.
cloud-fan
reviewed
Jan 12, 2017
| } catch { | ||
| case e @(_: RuntimeException | _: IOException) => | ||
| logWarning(s"Skipped the rest content in the corrupted file: $currentFile", e) | ||
| null |
cloud-fan
reviewed
Jan 12, 2017
| try { | ||
| // The readFunction may read files before consuming the iterator. | ||
| // E.g., vectorized Parquet reader. | ||
| readFunction(currentFile) |
There was a problem hiding this comment.
is it possible that we can make readFunction guarantee that data reading must happen after the first Iterator.next?
There was a problem hiding this comment.
I think it is hard to guarantee this because readFunction is coming from individual data source. Even we can modify current data sources, we may not be able to prevent other data sources doing this.
|
LGTM |
|
Test build #71417 has finished for PR 16474 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jan 16, 2017
## What changes were proposed in this pull request? We have a config `spark.sql.files.ignoreCorruptFiles` which can be used to ignore corrupt files when reading files in SQL. Currently the `ignoreCorruptFiles` config has two issues and can't work for Parquet: 1. We only ignore corrupt files in `FileScanRDD` . Actually, we begin to read those files as early as inferring data schema from the files. For corrupt files, we can't read the schema and fail the program. A related issue reported at http://apache-spark-developers-list.1001551.n3.nabble.com/Skip-Corrupted-Parquet-blocks-footer-tc20418.html 2. In `FileScanRDD`, we assume that we only begin to read the files when starting to consume the iterator. However, it is possibly the files are read before that. In this case, `ignoreCorruptFiles` config doesn't work too. This patch targets Parquet datasource. If this direction is ok, we can address the same issue for other datasources like Orc. Two main changes in this patch: 1. Replace `ParquetFileReader.readAllFootersInParallel` by implementing the logic to read footers in multi-threaded manner We can't ignore corrupt files if we use `ParquetFileReader.readAllFootersInParallel`. So this patch implements the logic to do the similar thing in `readParquetFootersInParallel`. 2. In `FileScanRDD`, we need to ignore corrupt file too when we call `readFunction` to return iterator. One thing to notice is: We read schema from Parquet file's footer. The method to read footer `ParquetFileReader.readFooter` throws `RuntimeException`, instead of `IOException`, if it can't successfully read the footer. Please check out https://github.com/apache/parquet-mr/blob/df9d8e415436292ae33e1ca0b8da256640de9710/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L470. So this patch catches `RuntimeException`. One concern is that it might also shadow other runtime exceptions other than reading corrupt files. ## How was this patch tested? Jenkins tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes #16474 from viirya/fix-ignorecorrupted-parquet-files. (cherry picked from commit 61e48f5) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
thanks, merging to master/2.1! |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? We have a config `spark.sql.files.ignoreCorruptFiles` which can be used to ignore corrupt files when reading files in SQL. Currently the `ignoreCorruptFiles` config has two issues and can't work for Parquet: 1. We only ignore corrupt files in `FileScanRDD` . Actually, we begin to read those files as early as inferring data schema from the files. For corrupt files, we can't read the schema and fail the program. A related issue reported at http://apache-spark-developers-list.1001551.n3.nabble.com/Skip-Corrupted-Parquet-blocks-footer-tc20418.html 2. In `FileScanRDD`, we assume that we only begin to read the files when starting to consume the iterator. However, it is possibly the files are read before that. In this case, `ignoreCorruptFiles` config doesn't work too. This patch targets Parquet datasource. If this direction is ok, we can address the same issue for other datasources like Orc. Two main changes in this patch: 1. Replace `ParquetFileReader.readAllFootersInParallel` by implementing the logic to read footers in multi-threaded manner We can't ignore corrupt files if we use `ParquetFileReader.readAllFootersInParallel`. So this patch implements the logic to do the similar thing in `readParquetFootersInParallel`. 2. In `FileScanRDD`, we need to ignore corrupt file too when we call `readFunction` to return iterator. One thing to notice is: We read schema from Parquet file's footer. The method to read footer `ParquetFileReader.readFooter` throws `RuntimeException`, instead of `IOException`, if it can't successfully read the footer. Please check out https://github.com/apache/parquet-mr/blob/df9d8e415436292ae33e1ca0b8da256640de9710/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L470. So this patch catches `RuntimeException`. One concern is that it might also shadow other runtime exceptions other than reading corrupt files. ## How was this patch tested? Jenkins tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes apache#16474 from viirya/fix-ignorecorrupted-parquet-files.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
## What changes were proposed in this pull request? We have a config `spark.sql.files.ignoreCorruptFiles` which can be used to ignore corrupt files when reading files in SQL. Currently the `ignoreCorruptFiles` config has two issues and can't work for Parquet: 1. We only ignore corrupt files in `FileScanRDD` . Actually, we begin to read those files as early as inferring data schema from the files. For corrupt files, we can't read the schema and fail the program. A related issue reported at http://apache-spark-developers-list.1001551.n3.nabble.com/Skip-Corrupted-Parquet-blocks-footer-tc20418.html 2. In `FileScanRDD`, we assume that we only begin to read the files when starting to consume the iterator. However, it is possibly the files are read before that. In this case, `ignoreCorruptFiles` config doesn't work too. This patch targets Parquet datasource. If this direction is ok, we can address the same issue for other datasources like Orc. Two main changes in this patch: 1. Replace `ParquetFileReader.readAllFootersInParallel` by implementing the logic to read footers in multi-threaded manner We can't ignore corrupt files if we use `ParquetFileReader.readAllFootersInParallel`. So this patch implements the logic to do the similar thing in `readParquetFootersInParallel`. 2. In `FileScanRDD`, we need to ignore corrupt file too when we call `readFunction` to return iterator. One thing to notice is: We read schema from Parquet file's footer. The method to read footer `ParquetFileReader.readFooter` throws `RuntimeException`, instead of `IOException`, if it can't successfully read the footer. Please check out https://github.com/apache/parquet-mr/blob/df9d8e415436292ae33e1ca0b8da256640de9710/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L470. So this patch catches `RuntimeException`. One concern is that it might also shadow other runtime exceptions other than reading corrupt files. ## How was this patch tested? Jenkins tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes apache#16474 from viirya/fix-ignorecorrupted-parquet-files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have a config
spark.sql.files.ignoreCorruptFileswhich can be used to ignore corrupt files when reading files in SQL. Currently theignoreCorruptFilesconfig has two issues and can't work for Parquet:FileScanRDD. Actually, we begin to read those files as early as inferring data schema from the files. For corrupt files, we can't read the schema and fail the program. A related issue reported at http://apache-spark-developers-list.1001551.n3.nabble.com/Skip-Corrupted-Parquet-blocks-footer-tc20418.htmlFileScanRDD, we assume that we only begin to read the files when starting to consume the iterator. However, it is possibly the files are read before that. In this case,ignoreCorruptFilesconfig doesn't work too.This patch targets Parquet datasource. If this direction is ok, we can address the same issue for other datasources like Orc.
Two main changes in this patch:
Replace
ParquetFileReader.readAllFootersInParallelby implementing the logic to read footers in multi-threaded mannerWe can't ignore corrupt files if we use
ParquetFileReader.readAllFootersInParallel. So this patch implements the logic to do the similar thing inreadParquetFootersInParallel.In
FileScanRDD, we need to ignore corrupt file too when we callreadFunctionto return iterator.One thing to notice is:
We read schema from Parquet file's footer. The method to read footer
ParquetFileReader.readFooterthrowsRuntimeException, instead ofIOException, if it can't successfully read the footer. Please check out https://github.com/apache/parquet-mr/blob/df9d8e415436292ae33e1ca0b8da256640de9710/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L470. So this patch catchesRuntimeException. One concern is that it might also shadow other runtime exceptions other than reading corrupt files.How was this patch tested?
Jenkins tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.