Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12757][CORE] lower "block locks were not released" log to info level #16513

Closed
wants to merge 1 commit into from

Conversation

felixcheung
Copy link
Member

@felixcheung felixcheung commented Jan 9, 2017

What changes were proposed in this pull request?

lower "block locks were not released" log to info level, as it is generating a lot of warnings in running ML, graph calls, as pointed out in the JIRA.

@felixcheung
Copy link
Member Author

@JoshRosen

@SparkQA
Copy link

SparkQA commented Jan 9, 2017

Test build #71067 has started for PR 16513 at commit dc81625.

@felixcheung
Copy link
Member Author

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Jan 9, 2017

Test build #71075 has finished for PR 16513 at commit dc81625.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 9, 2017

I think https://issues.apache.org/jira/browse/SPARK-13796 downgraded to warning from error; it might make sense to lower it further, but I'm not clear whether it should happen in normal operation? if not then it might be useful to keep the message until it's clear why this is happening reproducibly?

@felixcheung
Copy link
Member Author

@srowen completely agree. that was what I asked in https://issues.apache.org/jira/browse/SPARK-12757?focusedCommentId=15786726 and I'd defer to @JoshRosen who suggested lowering the log level

@felixcheung
Copy link
Member Author

merged to master. thanks!

@asfgit asfgit closed this in 2bc4d4e Jan 12, 2017
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
… level

## What changes were proposed in this pull request?

lower "block locks were not released" log to info level, as it is generating a lot of warnings in running ML, graph calls, as pointed out in the JIRA.

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#16513 from felixcheung/blocklockswarn.
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 15, 2017
… level

## What changes were proposed in this pull request?

lower "block locks were not released" log to info level, as it is generating a lot of warnings in running ML, graph calls, as pointed out in the JIRA.

Author: Felix Cheung <felixcheung_m@hotmail.com>

Closes apache#16513 from felixcheung/blocklockswarn.
@lujangus
Copy link

I'm seeing the same WARN when running LDA in Spark 2.1 in both the millib and ml libraries. When I run the LDA mllib implementation in Spark 1.6 I don't see the same error. For further information: LDA has two optimizers: "em" and "online" the error does not occur when running the "online" version. Is this the correct place to report this issue?

@henrymana
Copy link

I am still seeing the warning as well. I am using "0.5.0-spark2.1-s_2.11". Should we create a new issue or re-open this one?

@felixcheung
Copy link
Member Author

felixcheung commented Jun 14, 2017 via email

@runt1me
Copy link

runt1me commented Jul 7, 2017

as @lujangus noted, I also see this as a WARN after upgrading from Spark 1.6 -> 2.1 using mllib's LDA implementation. I actually get so many warnings that my stack eventually overflows, crashing the program. Is there a way to suppress these warnings?

@felixcheung
Copy link
Member Author

felixcheung commented Jul 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants