[SPARK-19157][SQL] should be able to change spark.sql.runSQLOnFiles at runtime #16531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gatorsmile |
tejasapatil
reviewed
Jan 10, 2017
| @@ -45,7 +45,7 @@ import org.apache.spark.unsafe.types.UTF8String | |||
| * Replaces generic operations with specific variants that are designed to work with Spark | |||
| * SQL Data Sources. | |||
| */ | |||
| case class DataSourceAnalysis(conf: CatalystConf) extends Rule[LogicalPlan] { | |||
There was a problem hiding this comment.
I looked at other places in the diff and not clear why you changed this to NOT be a case class.
There was a problem hiding this comment.
The same question. What is the reason why we made this change?
|
Test build #71136 has finished for PR 16531 at commit
|
gatorsmile
reviewed
Jan 10, 2017
| @@ -116,8 +116,8 @@ private[sql] class SessionState(sparkSession: SparkSession) { | |||
| AnalyzeCreateTable(sparkSession) :: | |||
| PreprocessTableInsertion(conf) :: | |||
| new FindDataSourceTable(sparkSession) :: | |||
| DataSourceAnalysis(conf) :: | |||
| (if (conf.runSQLonFile) new ResolveDataSource(sparkSession) :: Nil else Nil) | |||
There was a problem hiding this comment.
+1
This was the root cause why we were unable to change the conf at runtime.
|
LGTM except the question |
cloud-fan
force-pushed
the
sql-on-files
branch
from
963b66f
to
20b2d95
Compare
|
LGTM pending test |
|
Test build #71174 has finished for PR 16531 at commit
|
|
Thanks! Merging to master. |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…t runtime ## What changes were proposed in this pull request? The analyzer rule that supports to query files directly will be added to `Analyzer.extendedResolutionRules` when SparkSession is created, according to the `spark.sql.runSQLOnFiles` flag. If the flag is off when we create `SparkSession`, this rule is not added and we can not query files directly even we turn on the flag later. This PR fixes this bug by always adding that rule to `Analyzer.extendedResolutionRules`. ## How was this patch tested? new regression test Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16531 from cloud-fan/sql-on-files.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…t runtime ## What changes were proposed in this pull request? The analyzer rule that supports to query files directly will be added to `Analyzer.extendedResolutionRules` when SparkSession is created, according to the `spark.sql.runSQLOnFiles` flag. If the flag is off when we create `SparkSession`, this rule is not added and we can not query files directly even we turn on the flag later. This PR fixes this bug by always adding that rule to `Analyzer.extendedResolutionRules`. ## How was this patch tested? new regression test Author: Wenchen Fan <wenchen@databricks.com> Closes apache#16531 from cloud-fan/sql-on-files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The analyzer rule that supports to query files directly will be added to
Analyzer.extendedResolutionRuleswhen SparkSession is created, according to thespark.sql.runSQLOnFilesflag. If the flag is off when we createSparkSession, this rule is not added and we can not query files directly even we turn on the flag later.This PR fixes this bug by always adding that rule to
Analyzer.extendedResolutionRules.How was this patch tested?
new regression test