Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-19158][SPARKR][EXAMPLES] Fix ml.R example fails due to lack of e1071 package. #16548

Closed
wants to merge 1 commit into from
Closed

[SPARK-19158][SPARKR][EXAMPLES] Fix ml.R example fails due to lack of e1071 package. #16548

wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

What changes were proposed in this pull request?

ml.R example depends on e1071 package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency.

How was this patch tested?

Manual test.

srowen
srowen approved these changes Jan 11, 2017
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, why did this ever depend on e1071? doesn't seem essential.

@SparkQA
Copy link

SparkQA commented Jan 11, 2017

Test build #71204 has finished for PR 16548 at commit 5e2dd6b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jan 12, 2017
@yanboliang
[SPARK-19158][SPARKR][EXAMPLES] Fix ml.R example fails due to lack of…
0b07634 
… e1071 package.

## What changes were proposed in this pull request?
```ml.R``` example depends on ```e1071``` package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency.

## How was this patch tested?
Manual test.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #16548 from yanboliang/spark-19158.

(cherry picked from commit 2c586f5)
Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
@yanboliang
Copy link
Contributor Author

Merged into master and branch-2.1. Thanks for reviewing.

@asfgit asfgit closed this in 2c586f5 Jan 12, 2017
@yanboliang yanboliang deleted the spark-19158 branch January 12, 2017 09:03
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
@yanboliang @uzadude
[SPARK-19158][SPARKR][EXAMPLES] Fix ml.R example fails due to lack of…
4d0eac4 
… e1071 package.

## What changes were proposed in this pull request?
```ml.R``` example depends on ```e1071``` package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency.

## How was this patch tested?
Manual test.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#16548 from yanboliang/spark-19158.
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 15, 2017
@yanboliang @cmonkey
[SPARK-19158][SPARKR][EXAMPLES] Fix ml.R example fails due to lack of…
aa31697 
… e1071 package.

## What changes were proposed in this pull request?
```ml.R``` example depends on ```e1071``` package, if it's not available in users' environment, it will fail. I think the example should not depends on third-party packages, so I update it to remove the dependency.

## How was this patch tested?
Manual test.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#16548 from yanboliang/spark-19158.
@holdenk
Copy link
Contributor

holdenk commented Sep 25, 2017

So there is something similar in the fulltests for R ./R/pkg/tests/fulltests/test_mllib.R (found while working on packaging).

@yanboliang
Copy link
Contributor Author

@holdenk Could you let me know where we meet similar issue in the fulltests? AFAIK, we test functions in e1071 only when it was installed on that node, like following:

if (requireNamespace("e1071", quietly = TRUE)) {
    expect_error(m <- e1071::naiveBayes(Survived ~ ., data = t1), NA)
    expect_equal(as.character(predict(m, t1[1, ])), "Yes")
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanboliang @SparkQA @holdenk @srowen