[SPARK-17724][Streaming][WebUI] Unevaluated new lines in tooltip in DAG Visualization of a job #16643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his is new html5 attr
srowen
reviewed
Jan 19, 2017
| @@ -19,7 +19,7 @@ package org.apache.spark.ui.jobs | |||
|
|
|||
| import java.util.concurrent.TimeoutException | |||
|
|
|||
| import scala.collection.mutable.{HashMap, HashSet, LinkedHashMap, ListBuffer} | |||
There was a problem hiding this comment.
Although these other changes are not wrong, I don't think they're related. Best to stick to the core change you're making.
There was a problem hiding this comment.
I should undo these unrelated changes here, and leave them as they are?
|
Test build #71647 has finished for PR 16643 at commit
|
|
I checked this out and tested it and it runs well, code LGTM as well, but I agree that the unrelated changes should be removed. |
|
Test build #71695 has finished for PR 16643 at commit
|
srowen
reviewed
Jan 20, 2017
| * For tag 'tspan', line break '/n' is display in UI as raw for both stage page and job page, | ||
| * here this function is to enable line break. | ||
| */ | ||
| function intepreteLineBreak(svg) { |
felixcheung
reviewed
Jan 20, 2017
| * For tag 'tspan', line break '/n' is display in UI as raw for both stage page and job page, | ||
| * here this function is to enable line break. | ||
| */ | ||
| function intepreteLineBreak(svg) { |
There was a problem hiding this comment.
interpret actually lol...
|
sorry...tricky word "interpret" for a non-native English speaker... |
|
Test build #71726 has finished for PR 16643 at commit
|
|
Test build #71733 has finished for PR 16643 at commit
|
|
Test build #71732 has finished for PR 16643 at commit
|
|
Merged to master |
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Jan 22, 2017
… in DAG Visualization of a job apache#16643
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…AG Visualization of a job https://issues.apache.org/jira/browse/SPARK-17724 ## What changes were proposed in this pull request? For unevaluated `\n`, evaluate it and enable line break, for Streaming WebUI `stages` page and `job` page. (I didn't change Scala source file, since Jetty server has to somehow indicate line break and js to code display it.) (This PR is a continue from previous PR apache#15353 for the same issue, sorry being so long time) Two changes: 1. RDD Node tooltipText is actually showing the `<circle>` `title` property, so I set extra attribute in `spark-dag-viz.js`: `.attr("data-html", "true")` `<circle x="-5" y="-5" r="5" data-toggle="tooltip" data-placement="bottom" title="" data-original-title="ParallelCollectionRDD [9]\nmakeRDD at QueueStream.scala:49"></circle>` 2. Static `<tspan>` text of each stage, split by `/n`, and append an extra `<tspan>` element to its parentNode `<text><tspan xml:space="preserve" dy="1em" x="1">reduceByKey</tspan><tspan xml:space="preserve" dy="1em" x="1">reduceByKey/n 23:34:49</tspan></text> ` ## UI changes Screenshot **before fix**, `\n` is not evaluated in both circle tooltipText and static text:  Screenshot **after fix**:  ## How was this patch tested? Tested locally. For Streaming WebUI `stages` page and `job` page, on multiple browsers: - Chrome - Firefox - Safari Author: Xin Ren <renxin.ubc@gmail.com> Closes apache#16643 from keypointt/SPARK-17724-2nd.
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
…AG Visualization of a job https://issues.apache.org/jira/browse/SPARK-17724 ## What changes were proposed in this pull request? For unevaluated `\n`, evaluate it and enable line break, for Streaming WebUI `stages` page and `job` page. (I didn't change Scala source file, since Jetty server has to somehow indicate line break and js to code display it.) (This PR is a continue from previous PR apache#15353 for the same issue, sorry being so long time) Two changes: 1. RDD Node tooltipText is actually showing the `<circle>` `title` property, so I set extra attribute in `spark-dag-viz.js`: `.attr("data-html", "true")` `<circle x="-5" y="-5" r="5" data-toggle="tooltip" data-placement="bottom" title="" data-original-title="ParallelCollectionRDD [9]\nmakeRDD at QueueStream.scala:49"></circle>` 2. Static `<tspan>` text of each stage, split by `/n`, and append an extra `<tspan>` element to its parentNode `<text><tspan xml:space="preserve" dy="1em" x="1">reduceByKey</tspan><tspan xml:space="preserve" dy="1em" x="1">reduceByKey/n 23:34:49</tspan></text> ` ## UI changes Screenshot **before fix**, `\n` is not evaluated in both circle tooltipText and static text:  Screenshot **after fix**:  ## How was this patch tested? Tested locally. For Streaming WebUI `stages` page and `job` page, on multiple browsers: - Chrome - Firefox - Safari Author: Xin Ren <renxin.ubc@gmail.com> Closes apache#16643 from keypointt/SPARK-17724-2nd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-17724
What changes were proposed in this pull request?
For unevaluated
\n, evaluate it and enable line break, for Streaming WebUIstagespage andjobpage.(I didn't change Scala source file, since Jetty server has to somehow indicate line break and js to code display it.)
(This PR is a continue from previous PR #15353 for the same issue, sorry being so long time)
Two changes:
<circle>titleproperty, so I set extra attribute inspark-dag-viz.js:.attr("data-html", "true")<circle x="-5" y="-5" r="5" data-toggle="tooltip" data-placement="bottom" title="" data-original-title="ParallelCollectionRDD [9]\nmakeRDD at QueueStream.scala:49"></circle><tspan>text of each stage, split by/n, and append an extra<tspan>element to its parentNode<text><tspan xml:space="preserve" dy="1em" x="1">reduceByKey</tspan><tspan xml:space="preserve" dy="1em" x="1">reduceByKey/n@ 23:34:49</tspan></text>UI changes
Screenshot before fix,
\nis not evaluated in both circle tooltipText and static text:Screenshot after fix:
How was this patch tested?
Tested locally. For Streaming WebUI
stagespage andjobpage, on multiple browsers: