Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19384][ML] forget unpersist input dataset in IsotonicRegression #16718

Closed
wants to merge 1 commit into from

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

unpersist the input dataset if handlePersistence = true

How was this patch tested?

existing tests

@srowen
Copy link
Member

srowen commented Jan 27, 2017

That looks OK, but can you look for instances?

@zhengruifeng
Copy link
Contributor Author

@srowen I have use the regex to check other algs
find mllib/src -name '*.scala' | xargs -i bash -c 'egrep "handlePersistence" -n {} && echo {}'
and others seems ok.

@SparkQA
Copy link

SparkQA commented Jan 27, 2017

Test build #72071 has finished for PR 16718 at commit 5d2987b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 28, 2017

Merged to master

@asfgit asfgit closed this in 42ad93b Jan 28, 2017
@zhengruifeng zhengruifeng deleted the isoReg_unpersisit branch January 29, 2017 13:41
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 15, 2017
## What changes were proposed in this pull request?
unpersist the input dataset if `handlePersistence` = true

## How was this patch tested?
existing tests

Author: Zheng RuiFeng <ruifengz@foxmail.com>

Closes apache#16718 from zhengruifeng/isoReg_unpersisit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants