[SPARK-19441] [SQL] Remove IN type coercion from PromoteStrings #16783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #72300 has started for PR 16783 at commit |
|
retest this please |
|
Test build #72324 has finished for PR 16783 at commit
|
|
retest this please |
1 similar comment
|
retest this please |
|
Test build #72336 has finished for PR 16783 at commit
|
|
retest this please |
1 similar comment
|
retest this please |
|
Retest this please |
|
Test build #72400 has finished for PR 16783 at commit
|
|
+1 |
|
cc @cloud-fan |
|
retest this please |
|
Test build #72474 has finished for PR 16783 at commit
|
|
LGTM, merging to master! |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
### What changes were proposed in this pull request? The removed codes for `IN` are not reachable, because the previous rule `InConversion` already resolves the type coercion issues. ### How was this patch tested? N/A Author: gatorsmile <gatorsmile@gmail.com> Closes apache#16783 from gatorsmile/typeCoercionIn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The removed codes for
INare not reachable, because the previous ruleInConversionalready resolves the type coercion issues.How was this patch tested?
N/A