Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19398] Change one misleading log in TaskSetManager. #16807

Closed
wants to merge 1 commit into from

Conversation

jinxing64
Copy link

What changes were proposed in this pull request?

Log below is misleading:

if (successful(index)) {
  logInfo(
    s"Task ${info.id} in stage ${taskSet.id} (TID $tid) failed, " +
    "but another instance of the task has already succeeded, " +
    "so not re-queuing the task to be re-executed.")
}

If fetch failed, the task is marked as successful in TaskSetManager:: handleFailedTask. Then log above will be printed. The successful just means task will not be scheduled any longer, not a real success.

How was this patch tested?

Existing unit tests can cover this.

@jinxing64 jinxing64 closed this Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant