[SPARK-19533][EXAMPLES] Convert Java tests to use lambdas, Java 8 features #16961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to language level
srowen
commented
Feb 16, 2017
| @@ -40,7 +38,7 @@ | |||
| */ | |||
| public final class JavaLogQuery { | |||
|
|
|||
| public static final List<String> exampleApacheLogs = Lists.newArrayList( | |||
| public static final List<String> exampleApacheLogs = Arrays.asList( | |||
There was a problem hiding this comment.
Although this isn't specific to Java 8, the existence of Arrays.asList should mean we don't need Guava's Lists.newArrayList, and, we should prefer examples that don't involve third party libraries.
| @@ -32,9 +32,6 @@ | |||
| /** | |||
| * Java example demonstrating model selection using TrainValidationSplit. | |||
| * | |||
| * The example is based on {@link org.apache.spark.examples.ml.JavaSimpleParamsExample} | |||
There was a problem hiding this comment.
(This was a javadoc error, and inaccurate anyway)
| } | ||
| }, Encoders.STRING()); | ||
| Dataset<String> namesDS = namesDF.map( | ||
| (MapFunction<Row, String>) row -> "Name: " + row.getString(0), |
There was a problem hiding this comment.
For those wondering why this lambda has to be cast, it's because it is otherwise ambiguous, as there are two methods with an eligible function interface as arg.
|
Retest this please |
|
+1 LGTM! |
|
Test build #73013 has finished for PR 16961 at commit
|
|
whoa, nice/ |
srowen
changed the title
|
Merged to master |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Feb 19, 2017
…tures ## What changes were proposed in this pull request? Convert Java tests to use lambdas, Java 8 features. ## How was this patch tested? Jenkins tests. Author: Sean Owen <sowen@cloudera.com> Closes apache#16961 from srowen/SPARK-19533.
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…tures ## What changes were proposed in this pull request? Convert Java tests to use lambdas, Java 8 features. ## How was this patch tested? Jenkins tests. Author: Sean Owen <sowen@cloudera.com> Closes apache#16961 from srowen/SPARK-19533.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Convert Java tests to use lambdas, Java 8 features.
How was this patch tested?
Jenkins tests.