[SPARK-19658] [SQL] Set NumPartitions of RepartitionByExpression In Parser #16988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #73125 has finished for PR 16988 at commit
|
|
Test build #73130 has finished for PR 16988 at commit
|
|
how about we set the |
gatorsmile
commented
Feb 22, 2017
| (" sort by a, b desc", basePlan.sortBy('a.asc, 'b.desc)), | ||
| (" distribute by a, b", basePlan.distribute('a, 'b)()), | ||
| (" distribute by a sort by b", basePlan.distribute('a)().sortBy('b.asc)), | ||
| (" cluster by a, b", basePlan.distribute('a, 'b)().sortBy('a.asc, 'b.asc)) |
There was a problem hiding this comment.
These three test cases are moved to SparkSqlParserSuite.scala
gatorsmile
changed the title
|
@cloud-fan Great idea! |
|
Test build #73286 has finished for PR 16988 at commit
|
|
Test build #73288 has finished for PR 16988 at commit
|
cloud-fan
reviewed
Feb 22, 2017
| ctx: QueryOrganizationContext, | ||
| expressions: Seq[Expression], | ||
| query: LogicalPlan): LogicalPlan = { | ||
| RepartitionByExpression(expressions, query, conf.numShufflePartitions) |
There was a problem hiding this comment.
nit: indent is wrong here
|
Test build #73289 has finished for PR 16988 at commit
|
|
LGTM |
|
Test build #73293 has finished for PR 16988 at commit
|
|
thanks, merging to master! |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…rser ### What changes were proposed in this pull request? Currently, if `NumPartitions` is not set in RepartitionByExpression, we will set it using `spark.sql.shuffle.partitions` during Planner. However, this is not following the general resolution process. This PR is to set it in `Parser` and then `Optimizer` can use the value for plan optimization. ### How was this patch tested? Added a test case. Author: Xiao Li <gatorsmile@gmail.com> Closes apache#16988 from gatorsmile/resolveRepartition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, if
NumPartitionsis not set in RepartitionByExpression, we will set it usingspark.sql.shuffle.partitionsduring Planner. However, this is not following the general resolution process. This PR is to set it inParserand thenOptimizercan use the value for plan optimization.How was this patch tested?
Added a test case.