[SPARK-19886] Fix reportDataLoss if statement in SS KafkaSource #17228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Mar 9, 2017
|
Test build #74275 has finished for PR 17228 at commit
|
|
Test build #74276 has finished for PR 17228 at commit
|
|
LGTM too |
|
Test build #74277 has finished for PR 17228 at commit
|
|
Test build #74279 has finished for PR 17228 at commit
|
zsxwing
reviewed
Mar 10, 2017
| @@ -398,4 +386,23 @@ private[kafka010] object CachedKafkaConsumer extends Logging { | |||
| consumer | |||
| } | |||
| } | |||
|
|
|||
| private def reportDataLoss0( | |||
There was a problem hiding this comment.
Why not just move reportDataLoss here?
There was a problem hiding this comment.
The additionalInfo requires passing a lot more variables. I can pass all of it, but yeah
|
Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Mar 10, 2017
## What changes were proposed in this pull request? Fix the `throw new IllegalStateException` if statement part. ## How is this patch tested Regression test Author: Burak Yavuz <brkyvz@gmail.com> Closes #17228 from brkyvz/kafka-cause-fix. (cherry picked from commit 82138e0) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the
throw new IllegalStateExceptionif statement part.How is this patch tested
Regression test