Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-19988][TEST] Use the database after Hive's current Database is dropped #17344

Closed
wants to merge 1 commit into from

Conversation

gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Mar 19, 2017

What changes were proposed in this pull request?

This PR is to fix the following test failure in maven and the PR #15363.

org.apache.spark.sql.hive.orc.OrcSourceSuite SPARK-19459/SPARK-18220: read char/varchar column written by Hive

The test history shows all the maven builds failed this test case with the same error message.

FAILED: SemanticException [Error 10072]: Database does not exist: db2

      org.apache.spark.sql.execution.QueryExecutionException: FAILED: SemanticException [Error 10072]: Database does not exist: db2
      at org.apache.spark.sql.hive.client.HiveClientImpl$$anonfun$runHive$1.apply(HiveClientImpl.scala:637)
      at org.apache.spark.sql.hive.client.HiveClientImpl$$anonfun$runHive$1.apply(HiveClientImpl.scala:621)
      at org.apache.spark.sql.hive.client.HiveClientImpl$$anonfun$withHiveState$1.apply(HiveClientImpl.scala:288)
      at org.apache.spark.sql.hive.client.HiveClientImpl.liftedTree1$1(HiveClientImpl.scala:229)
      at org.apache.spark.sql.hive.client.HiveClientImpl.retryLocked(HiveClientImpl.scala:228)
      at org.apache.spark.sql.hive.client.HiveClientImpl.withHiveState(HiveClientImpl.scala:271)
      at org.apache.spark.sql.hive.client.HiveClientImpl.runHive(HiveClientImpl.scala:621)
      at org.apache.spark.sql.hive.client.HiveClientImpl.runSqlHive(HiveClientImpl.scala:611)
      at org.apache.spark.sql.hive.orc.OrcSuite$$anonfun$7.apply$mcV$sp(OrcSourceSuite.scala:160)
      at org.apache.spark.sql.hive.orc.OrcSuite$$anonfun$7.apply(OrcSourceSuite.scala:155)
      at org.apache.spark.sql.hive.orc.OrcSuite$$anonfun$7.apply(OrcSourceSuite.scala:155)
      at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
      at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
      at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
      at org.scalatest.Transformer.apply(Transformer.scala:22)
      at org.scalatest.Transformer.apply(Transformer.scala:20)
      at org.scalatest.FunSuiteLike$$anon$1.apply(FunSuiteLike.scala:166)
      at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:68)
      at org.scalatest.FunSuiteLike$class.invokeWithFixture$1(FunSuiteLike.scala:163)
      at org.scalatest.FunSuiteLike$$anonfun$runTest$1.apply(FunSuiteLike.scala:175)

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @windpiger

@SparkQA
Copy link

SparkQA commented Mar 19, 2017

Test build #74807 has started for PR 17344 at commit 90bd976.

@gatorsmile
Copy link
Member Author

This test case passed, but we still have multiple other test cases failed.

@windpiger
Copy link
Contributor

LGTM,but why maven test has this problem?

@gatorsmile
Copy link
Member Author

No idea. We need to monitor the mvn builds more closely. This flaky test case also impacts the sbt build.

Let me merge this first. Then, we can continue to clean the others.

@gatorsmile gatorsmile changed the title [SPARK-19990][TEST][test-maven][WIP] Use the database after Hive's current Database is dropped [SPARK-19990][TEST] Use the database after Hive's current Database is dropped Mar 19, 2017
@gatorsmile
Copy link
Member Author

Let us run the SBT build too.

@gatorsmile
Copy link
Member Author

test this please

@SparkQA
Copy link

SparkQA commented Mar 19, 2017

Test build #74829 has finished for PR 17344 at commit 90bd976.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

Thanks! Merging to master.

@asfgit asfgit closed this in 0ee9fbf Mar 19, 2017
@kayousterhout
Copy link
Contributor

It looks like this has the wrong JIRA id and should be SPARK-19988? I've marked that jira as resolved by this PR, but let me know if I've misunderstood things here.

@kayousterhout
Copy link
Contributor

Also @gatorsmile don't forget to update the corresponding JIRA when you merge a PR.

@gatorsmile
Copy link
Member Author

Sorry, I did not realize we have such a JIRA. We just hit it in another PR and simply fix it. Thanks!

Originally, I thought it was trivial, and thus I did not open a separate JIRA.

@gatorsmile gatorsmile changed the title [SPARK-19990][TEST] Use the database after Hive's current Database is dropped [SPARK-19988][TEST] Use the database after Hive's current Database is dropped Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants