Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20051][SS] Fix StreamSuite flaky test - recover from v2.1 checkpoint #17382

Closed
wants to merge 1 commit into from

Conversation

kunalkhamar
Copy link
Contributor

@kunalkhamar kunalkhamar commented Mar 21, 2017

What changes were proposed in this pull request?

There is a race condition between calling stop on a streaming query and deleting directories in withTempDir that causes test to fail, fixing to do lazy deletion using delete on shutdown JVM hook.

How was this patch tested?

  • Unit test
    • repeated 300 runs with no failure

@tdas
Copy link
Contributor

tdas commented Mar 22, 2017

LGTM. Will merge when tests pass.

@tdas
Copy link
Contributor

tdas commented Mar 22, 2017

Scala tests have passed. I am merging this to unblock other PRs.

@asfgit asfgit closed this in 2d73fcc Mar 22, 2017
@SparkQA
Copy link

SparkQA commented Mar 22, 2017

Test build #75014 has finished for PR 17382 at commit 8c0fcb1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kunalkhamar
Copy link
Contributor Author

@tdas all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants