[SPARK-20067] [SQL] Unify and Clean Up Desc Commands Using Catalog Interface #17394

gatorsmile · 2017-03-23T05:40:03Z

What changes were proposed in this pull request?

This PR is to unify and clean up the outputs of DESC EXTENDED/FORMATTED and SHOW TABLE EXTENDED by moving the logics into the Catalog interface. The output formats are improved. We also add the missing attributes. It impacts the DDL commands like SHOW TABLE EXTENDED, DESC EXTENDED and DESC FORMATTED.

In addition, by following what we did in Dataset API printSchema, we can use treeString to show the schema in the more readable way.

Below is the current way:

Schema: STRUCT<`a`: STRING (nullable = true), `b`: INT (nullable = true), `c`: STRING (nullable = true), `d`: STRING (nullable = true)>

After the change, it should look like

Schema: root
 |-- a: string (nullable = true)
 |-- b: integer (nullable = true)
 |-- c: string (nullable = true)
 |-- d: string (nullable = true)

How was this patch tested?

describe.sql and show-tables.sql

SparkQA · 2017-03-23T06:52:59Z

Test build #75082 has finished for PR 17394 at commit 8720919.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2017-03-23T09:16:26Z

Test build #75087 has finished for PR 17394 at commit d999147.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-03-23T16:31:41Z

cc @cloud-fan

cloud-fan · 2017-03-24T04:41:40Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

@@ -97,16 +97,21 @@ DESC EXTENDED t
 struct<col_name:string,data_type:string,comment:string>
 -- !query 6 output
 # Detailed Table Information	CatalogTable(


do we need to wrap the information with CatalogTable(...)?

Yes. Let me remove it and move it to the next line

The output looks weird if we sort the Command, so file a PR: #17414

gatorsmile · 2017-03-24T23:18:10Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

+ |-- a: string (nullable = true)
+ |-- b: integer (nullable = true)
+ |-- c: string (nullable = true)
+ |-- d: string (nullable = true)


@cloud-fan Do we still need Schema, if the above info already has it? The only missing part is the nullability, which can be put in comment or add a separate column.

yea we do not need, but I think CatalogTable.toString should still have the schema. Actually why do we have DESC EXTENDED? I think DESC FORMATTED is good enough

Below is what Programming Hive said:

Replacing EXTENDED with FORMATTED provides more readable but also more verbose output.

For most end-users, they should use DESC FORMATTED .

Maybe we can keep the output of DESC EXTENDED as it is. Then, we need to revisit DESC FORMATTED to ensure it includes all the user-facing metadata info.

SparkQA · 2017-03-25T00:25:29Z

Test build #75185 has finished for PR 17394 at commit 3859097.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2017-03-25T04:21:21Z

Test build #75200 has finished for PR 17394 at commit 1d72079.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-03-25T17:08:26Z

retest this please

SparkQA · 2017-03-25T19:32:04Z

Test build #75221 has finished for PR 17394 at commit 1d72079.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-03-26T02:54:12Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala

@@ -273,28 +278,32 @@ case class CatalogTable(
          if (bucketColumnNames.nonEmpty) s"Bucket Columns: $bucketColumnsString" else "",
          if (sortColumnNames.nonEmpty) s"Sort Columns: $sortColumnsString" else ""
        )
-
      case _ => Nil
    }


We should de-duplicate the codes.

SparkQA · 2017-03-26T08:26:42Z

Test build #75232 has finished for PR 17394 at commit 68bb05c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2017-03-26T20:23:04Z

Test build #75243 has finished for PR 17394 at commit ac3f351.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

viirya · 2017-03-27T02:31:24Z

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala

@@ -21,6 +21,7 @@ import java.net.URI
 import java.util.Date

 import com.google.common.base.Objects
+import scala.collection.mutable


Usually we put the imports of scala library above third-party.

If we change the order, can scalastyle pass?

Usually, the import order is:

import java.util.Date import scala.collection.mutable import com.google.common.base.Objects

Dataset.scala is an example.

viirya · 2017-03-27T02:33:07Z

Please update the PR description too since you update the title.

cloud-fan · 2017-03-27T04:07:23Z

after this PR, what's the difference between DESC EXTENDED and DESC FORMATTED?

gatorsmile · 2017-03-28T04:31:12Z

After refactoring, I think DESC FORMATTED might be more useful for users.

DESC FORMATTED outputs the metadata in a more formatted way. Users can query it using the key value (stored in col_name) to get the result. They do not need to parse the string to extract the data value, unlike DESC EXTENDED.

Below is the output of DESC FORMATTED

+----------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------+-------+
|col_name                    |data_type                                                                                                                                         |comment|
+----------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------+-------+
|key                         |int                                                                                                                                               |test   |
|value                       |string                                                                                                                                            |null   |
|ds                          |string                                                                                                                                            |null   |
|hr                          |string                                                                                                                                            |null   |
|# Partition Information     |                                                                                                                                                  |       |
|# col_name                  |data_type                                                                                                                                         |comment|
|ds                          |string                                                                                                                                            |null   |
|hr                          |string                                                                                                                                            |null   |
|                            |                                                                                                                                                  |       |
|# Detailed Table Information|                                                                                                                                                  |       |
|Table                       |`default`.`tab1`                                                                                                                                  |       |
|Owner                       |xiao                                                                                                                                              |       |
|Created                     |Mon Mar 27 21:25:07 PDT 2017                                                                                                                      |       |
|Last Access                 |Wed Dec 31 16:00:00 PST 1969                                                                                                                      |       |
|Type                        |EXTERNAL                                                                                                                                          |       |
|Provider                    |hive                                                                                                                                              |       |
|Comment                     |Apache Spark                                                                                                                                      |       |
|Properties                  |[serialization.format=1]                                                                                                                          |       |
|Location                    |file:/private/var/folders/6r/15tqm8hn3ldb3rmbfqm1gf4c0000gn/T/spark-8d941400-8f59-4080-8094-611fa517f11e                                          |       |
|Serde Library               |org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe                                                                                                |       |
|InputFormat                 |org.apache.hadoop.mapred.TextInputFormat                                                                                                          |       |
|OutputFormat                |org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat                                                                                        |       |
|Partition Provider          |Catalog                                                                                                                                           |       |
|Partition Columns           |[`ds`, `hr`]                                                                                                                                      |       |
|Schema                      |root
 |-- key: integer (nullable = true)
 |-- value: string (nullable = true)
 |-- ds: string (nullable = true)
 |-- hr: string (nullable = true)
|       |
+----------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------+-------+

Below is the output of DESC EXTENDED

+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------+-------+
|col_name                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               |data_type|comment|
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------+-------+
|key                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |int      |test   |
|value                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  |string   |null   |
|ds                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     |string   |null   |
|hr                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     |string   |null   |
|# Partition Information                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                |         |       |
|# col_name                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |data_type|comment|
|ds                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     |string   |null   |
|hr                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     |string   |null   |
|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |         |       |
|# Detailed Table Information                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |         |       |
|Table: `default`.`tab1`
Owner: xiao
Created: Mon Mar 27 21:25:07 PDT 2017
Last Access: Wed Dec 31 16:00:00 PST 1969
Type: EXTERNAL
Provider: hive
Comment: Apache Spark
Properties: [serialization.format=1]
Location: file:/private/var/folders/6r/15tqm8hn3ldb3rmbfqm1gf4c0000gn/T/spark-8d941400-8f59-4080-8094-611fa517f11e
Serde Library: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
InputFormat: org.apache.hadoop.mapred.TextInputFormat
OutputFormat: org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
Partition Provider: Catalog
Partition Columns: [`ds`, `hr`]
Schema: root
 |-- key: integer (nullable = true)
 |-- value: string (nullable = true)
 |-- ds: string (nullable = true)
 |-- hr: string (nullable = true)
|         |       |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------+-------+

SparkQA · 2017-03-28T04:57:33Z

Test build #75295 has started for PR 17394 at commit 29817ea.

SparkQA · 2017-03-28T06:04:32Z

Test build #75294 has finished for PR 17394 at commit bef1134.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

cloud-fan · 2017-03-28T06:19:34Z

seems DESC EXTENDED is totally useless... How about we deprecate DESC EXTENDED at parser and implement it with DESC FORMATTED?

gatorsmile · 2017-03-28T18:15:55Z

Yes. We do not need to keep the difference between DESC EXTENDED and DESC FORMATTED

SparkQA · 2017-04-01T06:00:07Z

Test build #75440 has finished for PR 17394 at commit e116018.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

cloud-fan · 2017-04-01T13:45:20Z

sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala

@@ -214,6 +215,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
    // Returns true if the plan is supposed to be sorted.
    def isSorted(plan: LogicalPlan): Boolean = plan match {


maybe call it needSort?

cloud-fan · 2017-04-01T13:48:40Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

+
+# Detailed Table Information	                    	                    
+Table               	`default`.`t`       	                    
+Created[removed by SQLQueryTestSuite]


this looks weird, how about Created [not included in comparison]

cloud-fan · 2017-04-01T13:50:19Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

+Location[removed by SQLQueryTestSuite]sql/core/spark-warehouse/t	                    
+Partition Provider  	Catalog             	                    
+Partition Columns   	[`c`, `d`]          	                    
+Schema              	root


this information is duplicated

Let me remove both

cloud-fan · 2017-04-01T13:51:11Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

-d                   	string
+
+# Detailed Table Information	                    	                    
+Table               	`default`.`t`       	                    


shall we separate it into 2 lines, Database and Table?

cloud-fan · 2017-04-01T13:57:47Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

-Detailed Partition Information CatalogPartition(
-	Partition Values: [c=Us, d=1]
-	Storage(Location: sql/core/spark-warehouse/t/c=Us/d=1)
-	Partition Parameters:{})	                    	                    
 a                   	string              	                    


we should add a header here # col_name data_type comment.

cloud-fan · 2017-04-01T14:14:58Z

sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala

-      buffer: ArrayBuffer[Row]): Unit = {
-    append(buffer, "", "", "")
-    append(buffer, "Detailed Partition Information " + partition.toString, "", "")
+    if (isExtended) describeFormattedDetailedPartitionInfo(table, metadata, partition, result)


not related to this PR, but it looks weird that DESC tbl and DESC tbl PARTITION (xxx) has the same result.

This function describeDetailedPartitionInfo will only be called for the DDL command

DESCRIBE [EXTENDED|FORMATTED] table_name PARTITION (partitionVal*)

cloud-fan · 2017-04-01T14:18:03Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

+
+# Detailed Partition Information	                    	                    
+Database            	default             	                    
+Table               	t                   	                    


not related to this PR, but why do we put the Database and Table in # Detailed Partition Information? Did we follow hive?

Yes.

hive> DESC EXTENDED page_view PARTITION(dt='part1', country='part2'); OK viewtime int userid bigint page_url string referrer_url string ip string IP Address of the User dt string country string # Partition Information # col_name data_type comment dt string country string Detailed Partition Information Partition(values:[part1, part2], dbName:default, tableName:page_view, createTime:1491066325, lastAccessTime:0, sd:StorageDescriptor(cols:[FieldSchema(name:viewtime, type:int, comment:null), FieldSchema(name:userid, type:bigint, comment:null), FieldSchema(name:page_url, type:string, comment:null), FieldSchema(name:referrer_url, type:string, comment:null), FieldSchema(name:ip, type:string, comment:IP Address of the User), FieldSchema(name:dt, type:string, comment:null), FieldSchema(name:country, type:string, comment:null)], location:file:/user/hive/warehouse/page_view/dt=part1/country=part2, inputFormat:org.apache.hadoop.mapred.SequenceFileInputFormat, outputFormat:org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat, compressed:false, numBuckets:-1, serdeInfo:SerDeInfo(name:null, serializationLib:org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe, parameters:{serialization.format=1}), bucketCols:[], sortCols:[], parameters:{}, skewedInfo:SkewedInfo(skewedColNames:[], skewedColValues:[], skewedColValueLocationMaps:{}), storedAsSubDirectories:false), parameters:{totalSize=0, numRows=0, rawDataSize=0, COLUMN_STATS_ACCURATE={"BASIC_STATS":"true"}, numFiles=0, transient_lastDdlTime=1491066325})

SparkQA · 2017-04-01T19:03:46Z

Test build #75446 has finished for PR 17394 at commit a6db8a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-04-02T01:12:19Z

sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala

-  }
-}
-
-case class SimpleDDLScan(


These two classes are moved to DataSourceTest.scala

SparkQA · 2017-04-02T03:38:59Z

Test build #75455 has finished for PR 17394 at commit 43668be.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DDLScanSource extends RelationProvider
case class SimpleDDLScan(

cloud-fan · 2017-04-02T03:39:11Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out



-- !query 7
+-- !query 10
 DESC t PARTITION (c='Us', d=1)


This has the same result with DESC t, is it same with Hive?

Yes.

hive> DESC page_view PARTITION(dt='part1', country='part2'); OK viewtime int userid bigint page_url string referrer_url string ip string IP Address of the User dt string country string # Partition Information # col_name data_type comment dt string country string Time taken: 0.12 seconds, Fetched: 13 row(s) hive> DESC page_view; OK viewtime int userid bigint page_url string referrer_url string ip string IP Address of the User dt string country string # Partition Information # col_name data_type comment dt string country string Time taken: 0.022 seconds, Fetched: 13 row(s)

cloud-fan · 2017-04-02T03:49:15Z

sql/core/src/test/resources/sql-tests/results/describe.sql.out

+Partition Values    	[c=Us, d=1]         	                    
+Location [not included in comparison]sql/core/spark-warehouse/t/c=Us/d=1	                    
+
+# Table Storage Information	                    	                    


why we have a new # Table Storage Information section for DESC EXTENDED t PARTITION (xxx)?

Hive does it. See the following output.

hive> DESC FORMATTED page_view PARTITION(dt='part1', country='part2'); OK # col_name data_type comment viewtime int userid bigint page_url string referrer_url string ip string IP Address of the User # Partition Information # col_name data_type comment dt string country string # Detailed Partition Information Partition Value: [part1, part2] Database: default Table: page_view CreateTime: Sat Apr 01 17:05:25 UTC 2017 LastAccessTime: UNKNOWN Location: file:/user/hive/warehouse/page_view/dt=part1/country=part2 Partition Parameters: COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"} numFiles 0 numRows 0 rawDataSize 0 totalSize 0 transient_lastDdlTime 1491066325 # Storage Information SerDe Library: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe InputFormat: org.apache.hadoop.mapred.SequenceFileInputFormat OutputFormat: org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat Compressed: No Num Buckets: -1 Bucket Columns: [] Sort Columns: [] Storage Desc Params: serialization.format 1 Time taken: 0.124 seconds, Fetched: 39 row(s) hive> DESC EXTENDED page_view PARTITION(dt='part1', country='part2'); OK viewtime int userid bigint page_url string referrer_url string ip string IP Address of the User dt string country string # Partition Information # col_name data_type comment dt string country string Detailed Partition Information Partition(values:[part1, part2], dbName:default, tableName:page_view, createTime:1491066325, lastAccessTime:0, sd:StorageDescriptor(cols:[FieldSchema(name:viewtime, type:int, comment:null), FieldSchema(name:userid, type:bigint, comment:null), FieldSchema(name:page_url, type:string, comment:null), FieldSchema(name:referrer_url, type:string, comment:null), FieldSchema(name:ip, type:string, comment:IP Address of the User), FieldSchema(name:dt, type:string, comment:null), FieldSchema(name:country, type:string, comment:null)], location:file:/user/hive/warehouse/page_view/dt=part1/country=part2, inputFormat:org.apache.hadoop.mapred.SequenceFileInputFormat, outputFormat:org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat, compressed:false, numBuckets:-1, serdeInfo:SerDeInfo(name:null, serializationLib:org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe, parameters:{serialization.format=1}), bucketCols:[], sortCols:[], parameters:{}, skewedInfo:SkewedInfo(skewedColNames:[], skewedColValues:[], skewedColValueLocationMaps:{}), storedAsSubDirectories:false), parameters:{totalSize=0, numRows=0, rawDataSize=0, COLUMN_STATS_ACCURATE={"BASIC_STATS":"true"}, numFiles=0, transient_lastDdlTime=1491066325}) Time taken: 0.116 seconds, Fetched: 15 row(s)

hive use # Storage Information, which seems to be the storage of the partition, not the table

Yes. Just checked the source code of Hive. This section in Hive is the storage for Partition, but the info was originally from the table storage, as shown in the codes. We did the same thing.

The only difference is our BucketSpec is not part of CatalogStorageFormat. Should we follow Hive to move it into CatalogStorageFormat? Or do it as a follow-up? After the move, we can easily output the exactly the same things as Hive.

Shall we rename this section to Storage Information? We may have per-partition storage in the future, although for now this is always table storage.

Sure, let me make the change.

cloud-fan · 2017-04-04T02:36:54Z

LGTM

SparkQA · 2017-04-04T03:35:42Z

Test build #75497 has finished for PR 17394 at commit 862a4d7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-04-04T06:30:30Z

Thanks! Merging to master.

dongjoon-hyun · 2017-06-05T06:03:44Z

Hi, All .
This seems to be incompatible changes even in DESC t from 2.2.0.
Is it better to be compatible on DESC t which has no EXTENDED|FORMATTED?

gatorsmile · 2017-06-05T06:12:13Z

Add the following line when issuing DESC t on partitioned tables?
# col_name data_type comment

dongjoon-hyun · 2017-06-05T06:22:00Z

Yep. That one.

dongjoon-hyun · 2017-06-05T06:22:54Z

It's reported at https://issues.apache.org/jira/browse/SPARK-20954 .
If the current one is better, could you give some advice on that? :)

dongjoon-hyun · 2017-06-05T06:25:27Z

What I mean is to remove # col_name data_type comment in case of DESC t.

gatorsmile · 2017-06-05T06:26:37Z

Sure, we can remove it. Feel free to submit a PR.

dongjoon-hyun · 2017-06-05T06:27:07Z

Thank you for advice. I'll make a PR soon.

dongjoon-hyun · 2017-06-05T16:43:54Z

Hi, All.
I made a PR, #18203.

gatorsmile added 2 commits March 22, 2017 19:41

fix.

2ebeac8

improve

8720919

revert

d999147

cloud-fan reviewed Mar 24, 2017

View reviewed changes

address comments.

3859097

gatorsmile commented Mar 24, 2017

View reviewed changes

fixed the test case

1d72079

gatorsmile commented Mar 26, 2017

View reviewed changes

fix.

68bb05c

gatorsmile changed the title ~~[SPARK-20067] [SQL] Use treeString to print out the table schema for CatalogTable~~ [SPARK-20067] [SQL] Unify and Clean Up Desc Commands Using Catalog Interface Mar 26, 2017

migrate the test case

ac3f351

viirya reviewed Mar 27, 2017

View reviewed changes

remove :

bef1134

test case fix.

29817ea

cloud-fan reviewed Apr 1, 2017

View reviewed changes

address comments.

a6db8a3

fix the test cases

43668be

gatorsmile commented Apr 2, 2017

View reviewed changes

cloud-fan reviewed Apr 2, 2017

View reviewed changes

address comments.

862a4d7

asfgit closed this in 51d3c85 Apr 4, 2017

gengliangwang mentioned this pull request Feb 28, 2022

[SPARK-38350][SQL] Make the table name output of V1/V2 "desc extended table" consistent #35681

Closed

		@@ -214,6 +215,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
		// Returns true if the plan is supposed to be sorted.
		def isSorted(plan: LogicalPlan): Boolean = plan match {

[SPARK-20067] [SQL] Unify and Clean Up Desc Commands Using Catalog Interface #17394

[SPARK-20067] [SQL] Unify and Clean Up Desc Commands Using Catalog Interface #17394

Conversation

gatorsmile commented Mar 23, 2017 • edited Loading

What changes were proposed in this pull request?

How was this patch tested?

SparkQA commented Mar 23, 2017

SparkQA commented Mar 23, 2017

gatorsmile commented Mar 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gatorsmile Mar 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SparkQA commented Mar 25, 2017

SparkQA commented Mar 25, 2017

gatorsmile commented Mar 25, 2017

SparkQA commented Mar 25, 2017

Choose a reason for hiding this comment

SparkQA commented Mar 26, 2017

SparkQA commented Mar 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viirya commented Mar 27, 2017

cloud-fan commented Mar 27, 2017

gatorsmile commented Mar 28, 2017

SparkQA commented Mar 28, 2017

SparkQA commented Mar 28, 2017

cloud-fan commented Mar 28, 2017

gatorsmile commented Mar 28, 2017

SparkQA commented Apr 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SparkQA commented Apr 1, 2017

Choose a reason for hiding this comment

SparkQA commented Apr 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cloud-fan commented Apr 4, 2017

SparkQA commented Apr 4, 2017

gatorsmile commented Apr 4, 2017

dongjoon-hyun commented Jun 5, 2017

gatorsmile commented Jun 5, 2017

dongjoon-hyun commented Jun 5, 2017

dongjoon-hyun commented Jun 5, 2017

dongjoon-hyun commented Jun 5, 2017 • edited Loading

gatorsmile commented Jun 5, 2017

dongjoon-hyun commented Jun 5, 2017

dongjoon-hyun commented Jun 5, 2017

gatorsmile commented Mar 23, 2017 •

edited

Loading

gatorsmile Mar 24, 2017 •

edited

Loading

dongjoon-hyun commented Jun 5, 2017 •

edited

Loading