[SPARK-20264][SQL] asm should be non-test dependency in sql/core

[rxin]

What changes were proposed in this pull request?

sq/core module currently declares asm as a test scope dependency. Transitively it should actually be a normal dependency since the actual core module defines it. This occasionally confuses IntelliJ.

How was this patch tested?

N/A - This is a build change.

[SparkQA]

Test build #75618 has started for PR 17574 at commit 2a03188.

[SparkQA]

Test build #3648 has finished for PR 17574 at commit 2a03188.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[viirya]

retest this please.

[viirya]

Do we need it as a normal dependency? Looks like sql/core doesn't use it and the building works without this dependency. Sorry if I am missing something.

[SparkQA]

Test build #75623 has finished for PR 17574 at commit 2a03188.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[viirya]

retest this please.

[SparkQA]

Test build #75626 has finished for PR 17574 at commit 2a03188.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

LGTM

[gatorsmile]

Thanks! Merging to master/2.1

[gatorsmile]

@viirya Based on the code change history, #13642 removed the usage of ASM in the test case SQLMetricsSuite.scala. Thus, it is safe to remove the test dependency.

I am not 100% sure whether sql/core has any dependence on it. What I saw in the history is the PR #9512 added it for testing only.

[viirya]

@gatorsmile Thanks for the search. I don't see any usage of it in sql/core now. It is only used in core, repl, graphx. So I am wondering if we can completely remove it from the dependency.

[gatorsmile]

You can make a try.

[rxin]

Meh let's not bother. There isn't any harm in the current setup since it's already a transitive dependency. Why waste time on those?

[srowen]

BTW making it compile scope means it is still also in test scope, which is fine.
I actually don't see xbean as a transitive dependency otherwise? at least from Maven and SBT as best I know how to use them to find out.