[SPARK-20284][CORE] Make {Des,S}erializationStream extend Closeable #17598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to use these streams in try-with-resources.
srowen
reviewed
Apr 10, 2017
| @@ -125,7 +125,7 @@ abstract class SerializerInstance { | |||
| * A stream for writing serialized objects. | |||
| */ | |||
| @DeveloperApi | |||
| abstract class SerializationStream { | |||
| abstract class SerializationStream extends Closeable { | |||
There was a problem hiding this comment.
Does the close() method need 'override' then?
There was a problem hiding this comment.
Sure, added that.
|
Test build #3659 has finished for PR 17598 at commit
|
srowen
approved these changes
Apr 12, 2017
There was a problem hiding this comment.
My only concern would be whether this changes the classes in a way that makes them subtly not compatible at runtime. MiMa doesn't seem to think so though, and it's a developer API, and I also can't think of why it would change compatibility of bytecode (close() method already exists) So I think this is OK.
|
Merged to master |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
## What changes were proposed in this pull request? This PR allows to use `SerializationStream` and `DeserializationStream` in try-with-resources. ## How was this patch tested? `core` unit tests. Author: Sergei Lebedev <s.lebedev@criteo.com> Closes apache#17598 from superbobry/compression-stream-closeable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR allows to use
SerializationStreamandDeserializationStreamin try-with-resources.How was this patch tested?
coreunit tests.