[SPARK-20289][SQL] Use StaticInvoke to box primitive types #17604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Apr 11, 2017
| @@ -204,37 +204,37 @@ object ScalaReflection extends ScalaReflection { | |||
| case t if t <:< localTypeOf[java.lang.Integer] => | |||
| val boxedType = classOf[java.lang.Integer] | |||
| val objectType = ObjectType(boxedType) | |||
| NewInstance(boxedType, getPath :: Nil, objectType) | |||
| StaticInvoke(boxedType, objectType, "valueOf", getPath :: Nil, propagateNull = true) | |||
There was a problem hiding this comment.
propagateNull is true by default, maybe omit it?
|
LGTM |
srowen
reviewed
Apr 11, 2017
| NewInstance(c, getPath :: Nil, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Boolean] => | ||
| NewInstance(c, getPath :: Nil, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Short] || |
There was a problem hiding this comment.
Is this simpler as
case c: java.lang.Short | java.lang.Integer | java.lang.Long | ... =>
I believe it's the same thing but don't know if it is implemented in a meaningfully different way. Seems like it ought to be no worse at runtime but I don't know.
There was a problem hiding this comment.
Ugh right ignore that. Not thinking straight.
|
Test build #75698 has finished for PR 17604 at commit
|
|
Merging in master. |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
## What changes were proposed in this pull request? Dataset typed API currently uses NewInstance to box primitive types (i.e. calling the constructor). Instead, it'd be slightly more idiomatic in Java to use PrimitiveType.valueOf, which can be invoked using StaticInvoke expression. ## How was this patch tested? The change should be covered by existing tests for Dataset encoders. Author: Reynold Xin <rxin@databricks.com> Closes apache#17604 from rxin/SPARK-20289.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Dataset typed API currently uses NewInstance to box primitive types (i.e. calling the constructor). Instead, it'd be slightly more idiomatic in Java to use PrimitiveType.valueOf, which can be invoked using StaticInvoke expression.
How was this patch tested?
The change should be covered by existing tests for Dataset encoders.