Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20300][ML][PYSPARK] Python API for ALSModel.recommendForAllUsers,Items #17622

Closed
wants to merge 2 commits into from

Conversation

MLnick
Copy link
Contributor

@MLnick MLnick commented Apr 12, 2017

Add Python API for ALSModel methods recommendForAllUsers, recommendForAllItems

How was this patch tested?

New doc tests.

@MLnick
Copy link
Contributor Author

MLnick commented Apr 12, 2017

cc @jkbradley

@SparkQA
Copy link

SparkQA commented Apr 12, 2017

Test build #75745 has finished for PR 17622 at commit abe6cfb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

"""
Returns top `numUsers` users recommended for each item, for all items.

:param numItems: max number of recommendations for each item
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numItems -> numUsers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@viirya
Copy link
Member

viirya commented Apr 17, 2017

LGTM except for a doc comment.

@SparkQA
Copy link

SparkQA commented Apr 24, 2017

Test build #76099 has finished for PR 17622 at commit 7644e51.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Contributor Author

MLnick commented Apr 24, 2017

If no other comments (@jkbradley) I will merge to branch-2.2 in a few days.

@MLnick
Copy link
Contributor Author

MLnick commented May 2, 2017

Merged to master/branch-2.2

asfgit pushed a commit that referenced this pull request May 2, 2017
…rs,Items

Add Python API for `ALSModel` methods `recommendForAllUsers`, `recommendForAllItems`

## How was this patch tested?

New doc tests.

Author: Nick Pentreath <nickp@za.ibm.com>

Closes #17622 from MLnick/SPARK-20300-pyspark-recall.

(cherry picked from commit e300a5a)
Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
@asfgit asfgit closed this in e300a5a May 2, 2017
@MLnick MLnick deleted the SPARK-20300-pyspark-recall branch May 2, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants