-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-20300][ML][PYSPARK] Python API for ALSModel.recommendForAllUsers,Items #17622
Conversation
cc @jkbradley |
Test build #75745 has finished for PR 17622 at commit
|
python/pyspark/ml/recommendation.py
Outdated
""" | ||
Returns top `numUsers` users recommended for each item, for all items. | ||
|
||
:param numItems: max number of recommendations for each item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numItems -> numUsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM except for a doc comment. |
Test build #76099 has finished for PR 17622 at commit
|
If no other comments (@jkbradley) I will merge to branch-2.2 in a few days. |
Merged to master/branch-2.2 |
…rs,Items Add Python API for `ALSModel` methods `recommendForAllUsers`, `recommendForAllItems` ## How was this patch tested? New doc tests. Author: Nick Pentreath <nickp@za.ibm.com> Closes #17622 from MLnick/SPARK-20300-pyspark-recall. (cherry picked from commit e300a5a) Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
Add Python API for
ALSModel
methodsrecommendForAllUsers
,recommendForAllItems
How was this patch tested?
New doc tests.