[SPARK-20335] [SQL] Children expressions of Hive UDF impacts the determinism of Hive UDF #17635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Apr 14, 2017
| @@ -509,6 +509,19 @@ abstract class AggregationQuerySuite extends QueryTest with SQLTestUtils with Te | |||
| Row(null, null, 110.0, null, null, 10.0) :: Nil) | |||
| } | |||
|
|
|||
| test("non-deterministic children expressions of UDAF") { | |||
There was a problem hiding this comment.
This is just to improve the test case coverage.
gatorsmile
commented
Apr 14, 2017
| @@ -84,6 +85,21 @@ class HiveUDAFSuite extends QueryTest with TestHiveSingleton with SQLTestUtils { | |||
| Row(1, Row(1, 1)) | |||
| )) | |||
| } | |||
|
|
|||
| test("non-deterministic children expressions of UDAF") { | |||
There was a problem hiding this comment.
This is just to improve the test case coverage.
|
Test build #75793 has started for PR 17635 at commit |
|
Test build #75791 has finished for PR 17635 at commit
|
viirya
reviewed
Apr 14, 2017
| test("non-deterministic children expressions of UDAF") { | ||
| withTempView("view1") { | ||
| spark.range(1).selectExpr("id as x", "id as y").createTempView("view1") | ||
| withUserDefinedFunction("testUDAFPercentile" -> true, "testMock" -> true) { |
|
LGTM except a minor comment on the test. |
|
Test build #75824 has finished for PR 17635 at commit
|
|
cc @cloud-fan |
|
+1 |
|
LGTM, merging to master! @gatorsmile shall we backport this PR? |
|
Maybe, yes. Will do it later. Thank you! |
asfgit
pushed a commit
that referenced
this pull request
Apr 17, 2017
…acts the determinism of Hive UDF ### What changes were proposed in this pull request? This PR is to backport #17635 to Spark 2.1 --- ```JAVA /** * Certain optimizations should not be applied if UDF is not deterministic. * Deterministic UDF returns same result each time it is invoked with a * particular input. This determinism just needs to hold within the context of * a query. * * return true if the UDF is deterministic */ boolean deterministic() default true; ``` Based on the definition of [UDFType](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFType.java#L42-L50), when Hive UDF's children are non-deterministic, Hive UDF is also non-deterministic. ### How was this patch tested? Added test cases. Author: Xiao Li <gatorsmile@gmail.com> Closes #17652 from gatorsmile/backport-17635.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…minism of Hive UDF ### What changes were proposed in this pull request? ```JAVA /** * Certain optimizations should not be applied if UDF is not deterministic. * Deterministic UDF returns same result each time it is invoked with a * particular input. This determinism just needs to hold within the context of * a query. * * return true if the UDF is deterministic */ boolean deterministic() default true; ``` Based on the definition of [UDFType](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFType.java#L42-L50), when Hive UDF's children are non-deterministic, Hive UDF is also non-deterministic. ### How was this patch tested? Added test cases. Author: Xiao Li <gatorsmile@gmail.com> Closes apache#17635 from gatorsmile/udfDeterministic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Based on the definition of UDFType, when Hive UDF's children are non-deterministic, Hive UDF is also non-deterministic.
How was this patch tested?
Added test cases.