Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20404][CORE] Using Option(name) instead of Some(name) #17740

Closed
wants to merge 1 commit into from

Conversation

szhem
Copy link
Contributor

@szhem szhem commented Apr 24, 2017

Using Option(name) instead of Some(name) to prevent runtime failures when using accumulators created like the following

sparkContext.accumulator(0, null)

@szhem szhem changed the title [SPARK-SPARK-20404][CORE] Using Option(name) instead of Some(name) [SPARK-20404][CORE] Using Option(name) instead of Some(name) Apr 24, 2017
…ating accumulators to prevent failures at runtime when using null names
@szhem szhem force-pushed the SPARK-20404-null-acc-names branch from 9c6e4d6 to e12058c Compare April 24, 2017 09:15
@SparkQA
Copy link

SparkQA commented Apr 24, 2017

Test build #3674 has finished for PR 17740 at commit e12058c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Apr 25, 2017
Using Option(name) instead of Some(name) to prevent runtime failures when using accumulators created like the following
```
sparkContext.accumulator(0, null)
```

Author: Sergey Zhemzhitsky <szhemzhitski@gmail.com>

Closes #17740 from szhem/SPARK-20404-null-acc-names.

(cherry picked from commit 0bc7a90)
Signed-off-by: Sean Owen <sowen@cloudera.com>
asfgit pushed a commit that referenced this pull request Apr 25, 2017
Using Option(name) instead of Some(name) to prevent runtime failures when using accumulators created like the following
```
sparkContext.accumulator(0, null)
```

Author: Sergey Zhemzhitsky <szhemzhitski@gmail.com>

Closes #17740 from szhem/SPARK-20404-null-acc-names.

(cherry picked from commit 0bc7a90)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented Apr 25, 2017

Merged to master/2.2/2.1

@asfgit asfgit closed this in 0bc7a90 Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants