Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-13747][Core]Add ThreadUtils.awaitReady and disallow Await.ready #17763

Closed
wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Apr 25, 2017

What changes were proposed in this pull request?

Add ThreadUtils.awaitReady similar to ThreadUtils.awaitResult and disallow Await.ready.

How was this patch tested?

Jenkins

@SparkQA
Copy link

SparkQA commented Apr 25, 2017

Test build #76149 has finished for PR 17763 at commit e79a05a.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 25, 2017

Test build #76150 has finished for PR 17763 at commit f10461b.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 26, 2017

Test build #76151 has finished for PR 17763 at commit 2bb83e1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented May 16, 2017

retest this please

@SparkQA
Copy link

SparkQA commented May 16, 2017

Test build #76977 has started for PR 17763 at commit 2bb83e1.

@zsxwing
Copy link
Member Author

zsxwing commented May 17, 2017

@yhuai could you take a look at this one since you reviewed the previous PR, please?

@yhuai
Copy link
Contributor

yhuai commented May 17, 2017

lgtm

@zsxwing
Copy link
Member Author

zsxwing commented May 18, 2017

Thanks! Merging to master and 2.2.

asfgit pushed a commit that referenced this pull request May 18, 2017
## What changes were proposed in this pull request?

Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes #17763 from zsxwing/awaitready.

(cherry picked from commit 324a904)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
@asfgit asfgit closed this in 324a904 May 18, 2017
@zsxwing zsxwing deleted the awaitready branch May 18, 2017 00:26
robert3005 pushed a commit to palantir/spark that referenced this pull request May 19, 2017
## What changes were proposed in this pull request?

Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#17763 from zsxwing/awaitready.
liyichao pushed a commit to liyichao/spark that referenced this pull request May 24, 2017
## What changes were proposed in this pull request?

Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`.

## How was this patch tested?

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#17763 from zsxwing/awaitready.
sumwale pushed a commit to TIBCOSoftware/snappy-spark that referenced this pull request Aug 12, 2021
Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`.

Jenkins

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#17763 from zsxwing/awaitready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants