-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13747][Core]Add ThreadUtils.awaitReady and disallow Await.ready #17763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test build #76149 has finished for PR 17763 at commit
|
Test build #76150 has finished for PR 17763 at commit
|
Test build #76151 has finished for PR 17763 at commit
|
retest this please |
Test build #76977 has started for PR 17763 at commit |
@yhuai could you take a look at this one since you reviewed the previous PR, please? |
lgtm |
Thanks! Merging to master and 2.2. |
asfgit
pushed a commit
that referenced
this pull request
May 18, 2017
## What changes were proposed in this pull request? Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes #17763 from zsxwing/awaitready. (cherry picked from commit 324a904) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
May 19, 2017
## What changes were proposed in this pull request? Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#17763 from zsxwing/awaitready.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#17763 from zsxwing/awaitready.
sumwale
pushed a commit
to TIBCOSoftware/snappy-spark
that referenced
this pull request
Aug 12, 2021
Add `ThreadUtils.awaitReady` similar to `ThreadUtils.awaitResult` and disallow `Await.ready`. Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#17763 from zsxwing/awaitready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
ThreadUtils.awaitReady
similar toThreadUtils.awaitResult
and disallowAwait.ready
.How was this patch tested?
Jenkins