[SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed Plans #17787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2017 11:52
bllchmbrs
changed the title
|
Test build #76236 has finished for PR 17787 at commit
|
brkyvz
reviewed
Apr 27, 2017
| /* No topic field or topic option */ | ||
| var writer: StreamingQuery = null | ||
| var ex: Exception = null | ||
| try { |
brkyvz
reviewed
Apr 27, 2017
| } | ||
| } finally { | ||
| } | ||
| assert(ex.getMessage |
There was a problem hiding this comment.
what is the error message when you undo your changes?
There was a problem hiding this comment.
"'writeStream' can be called only on streaming Dataset/DataFrame;"
|
Test build #76239 has finished for PR 17787 at commit
|
|
Test build #76241 has finished for PR 17787 at commit
|
added 2 commits
April 27, 2017 16:02
|
Test build #76247 has finished for PR 17787 at commit
|
|
Test build #76248 has finished for PR 17787 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This now asserts that a plan has been analyzed before reading the schema.
How was this patch tested?
Existing Tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.