Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20421][core] Add a missing deprecation tag. #17824

Closed
wants to merge 1 commit into from

Conversation

vanzin
Copy link
Contributor

@vanzin vanzin commented May 1, 2017

In the previous patch I deprecated StorageStatus, but not the
method in SparkContext that exposes that class publicly. So deprecate
the method too.

In the previous patch I deprecated StorageStatus, but not the
method in SparkContext that exposes that class publicly. So deprecate
the method too.
@jerryshao
Copy link
Contributor

jerryshao commented May 2, 2017

@vanzin are we going to remove these listeners in future, or just keep them as deprecated? I saw you already deprecated some listeners. Some projects like Zeppelin explicitly depends on these listeners not only for code simplicity, but also for spark1/spark2 compatibility (SparkListener's signature is changed in Spark2, directly depending on SparkListener requires code recompile, so cannot achieve one build to support both Spark1/Spark2).

@SparkQA
Copy link

SparkQA commented May 2, 2017

Test build #76364 has finished for PR 17824 at commit 15d1977.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented May 2, 2017

I'm planning to remove these listeners completely in 2.3. (StorageStatus, which is the theme of this particular PR, is not currently in my crosshair, but I may decide to clean that one up also.)

I'd suggest you look at alternative ways of getting the data you want (either the rest api or the SparkStatusTracker API).

@jerryshao
Copy link
Contributor

Thanks @vanzin ! SparkStatusTracker depends on JobProgressListener which was already deprecated, will you remove this JobProgressListener and rewrite SparkStatusTrack?

@vanzin
Copy link
Contributor Author

vanzin commented May 2, 2017

Yes SparkStatusTrack will keep working the same way it does today.

@vanzin
Copy link
Contributor Author

vanzin commented May 2, 2017

Merging to master / 2.2.

asfgit pushed a commit that referenced this pull request May 2, 2017
In the previous patch I deprecated StorageStatus, but not the
method in SparkContext that exposes that class publicly. So deprecate
the method too.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #17824 from vanzin/SPARK-20421.

(cherry picked from commit ef3df91)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@asfgit asfgit closed this in ef3df91 May 2, 2017
@vanzin vanzin deleted the SPARK-20421 branch May 31, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants