Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20981][SparkSubmit]Add new configuration spark.jars.repositories as equivalence of --repositories #18201

Closed
wants to merge 1 commit into from

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

In our use case of launching Spark applications via REST APIs (Livy), there's no way for user to specify command line arguments, all Spark configurations are set through configurations map. For "--repositories" because there's no equivalent Spark configuration, so we cannot specify the custom repository through configuration.

So here propose to add "--repositories" equivalent configuration in Spark.

How was this patch tested?

New UT added.

…ositories

Change-Id: I36538532cf952f148e7b121979a1860719bda75f
@SparkQA
Copy link

SparkQA commented Jun 5, 2017

Test build #77732 has started for PR 18201 at commit d64c7e9.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@srowen
Copy link
Member

srowen commented Jun 5, 2017

I guess the use case is like including some default 3rd part repos in spark-defaults.conf for all jobs? seems reasonable, CC @vanzin

@jerryshao
Copy link
Contributor Author

Yes, that's right.

@SparkQA
Copy link

SparkQA commented Jun 5, 2017

Test build #77736 has finished for PR 18201 at commit d64c7e9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Jun 5, 2017

LGTM. Merging to master.

@asfgit asfgit closed this in 06c0544 Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants