[SPARK-19660][SQL][FOLLOWUP] Replace mapred.input.dir.recursive to mapreduce.input.fileinputformat.input.dir.recursive #18361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….input.dir.recursive
|
Test build #78288 has finished for PR 18361 at commit
|
|
Retest this please. |
|
Test build #78322 has started for PR 18361 at commit |
|
test this please |
|
Test build #78339 has started for PR 18361 at commit |
|
Retest this please. |
|
Test build #78376 has finished for PR 18361 at commit
|
jiangxb1987
reviewed
Jul 12, 2017
| @@ -197,7 +197,7 @@ class HadoopMapRedWriteConfigUtil[K, V: ClassTag](conf: SerializableJobConf) | |||
| FileCommitProtocol.instantiate( | |||
| className = classOf[HadoopMapRedCommitProtocol].getName, | |||
| jobId = jobId.toString, | |||
| outputPath = getConf.get("mapred.output.dir"), | |||
| outputPath = getConf.get("mapreduce.output.fileoutputformat.outputdir"), | |||
There was a problem hiding this comment.
This is intended to support the old mapred API, see the comments above this class.
| @@ -265,7 +265,7 @@ private case class OutputCommitFunctions(tempDirPath: String) { | |||
| val committer = FileCommitProtocol.instantiate( | |||
| className = classOf[HadoopMapRedCommitProtocol].getName, | |||
| jobId = jobId.value.getId.toString, | |||
| outputPath = jobConf.get("mapred.output.dir"), | |||
| outputPath = jobConf.get("mapreduce.output.fileoutputformat.outputdir"), | |||
|
Test build #79563 has finished for PR 18361 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace
mapred.input.dir.recursivetomapreduce.input.fileinputformat.input.dir.recursive, this property did't record in DeprecatedProperties.html, but source code has.Some times also saw the deprecation info:
How was this patch tested?
Exists tests