[SPARK-21369][Core]Don't use Scala Tuple2 in common/network-* #18593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
changed the title
zsxwing
commented
Jul 10, 2017
| @@ -90,7 +90,8 @@ | |||
| <dependency> | |||
| <groupId>org.apache.spark</groupId> | |||
| <artifactId>spark-tags_${scala.binary.version}</artifactId> | |||
| </dependency> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
Changed this to not add Scala library into the compile scope.
zsxwing
commented
Jul 10, 2017
| return String.format("%d_%d", streamId, chunkId); | ||
| } | ||
|
|
||
| public static Tuple2<Long, Integer> parseStreamChunkId(String streamChunkId) { |
There was a problem hiding this comment.
the change in this file is just inlining this method.
|
LGTM. |
|
Also, an alternative would be to explicitly add the scala-library dependency in test scope, in case some future dependency re-adds it in compile scope. |
|
@vanzin it doesn't work. I added scala-library into the test scope and changed |
|
Test build #79479 has finished for PR 18593 at commit
|
jinxing64
approved these changes
Jul 11, 2017
|
LGTM |
|
LGTM, merging to master/2.2! |
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2017
## What changes were proposed in this pull request? Remove all usages of Scala Tuple2 from common/network-* projects. Otherwise, Yarn users cannot use `spark.reducer.maxReqSizeShuffleToMem`. ## How was this patch tested? Jenkins. Author: Shixiong Zhu <shixiong@databricks.com> Closes #18593 from zsxwing/SPARK-21369. (cherry picked from commit 833eab2) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
## What changes were proposed in this pull request? Remove all usages of Scala Tuple2 from common/network-* projects. Otherwise, Yarn users cannot use `spark.reducer.maxReqSizeShuffleToMem`. ## How was this patch tested? Jenkins. Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#18593 from zsxwing/SPARK-21369. (cherry picked from commit 833eab2) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove all usages of Scala Tuple2 from common/network-* projects. Otherwise, Yarn users cannot use
spark.reducer.maxReqSizeShuffleToMem.How was this patch tested?
Jenkins.