[SPARK-21551][Python] Increase timeout for PythonRDD.serveIterator #18752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JoshRosen |
|
Any chance we can merge this? |
|
This seems fine to me, especially since it's plausible that you might have a few-second GC pause in some situations. Let me go ahead and have Jenkins test this, then I'll merge it if tests pass (which I assume they will). |
|
Jenkins, this is ok to test. |
|
Test build #80419 has finished for PR 18752 at commit
|
|
Great, thanks @JoshRosen! |
|
Merging in master. |
This was referenced Oct 17, 2017
asfgit
pushed a commit
that referenced
this pull request
Oct 19, 2017
Backport of #18752 (https://issues.apache.org/jira/browse/SPARK-21551) (cherry picked from commit 9d3c664) Author: peay <peay@protonmail.com> Closes #19512 from FRosner/branch-2.2.
asfgit
pushed a commit
that referenced
this pull request
Oct 20, 2017
Backport of #18752 (https://issues.apache.org/jira/browse/SPARK-21551) (cherry picked from commit 9d3c664) Author: peay <peay@protonmail.com> Closes #19513 from FRosner/branch-2.1.
asfgit
pushed a commit
that referenced
this pull request
Oct 21, 2017
Backport of #18752 (https://issues.apache.org/jira/browse/SPARK-21551) (cherry picked from commit 9d3c664) Author: peay <peay@protonmail.com> Closes #19514 from FRosner/branch-2.0.
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
Backport of apache#18752 (https://issues.apache.org/jira/browse/SPARK-21551) (cherry picked from commit 9d3c664) Author: peay <peay@protonmail.com> Closes apache#19512 from FRosner/branch-2.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This modification increases the timeout for
serveIterator(which is not dynamically configurable). This fixes timeout issues in pyspark when usingcollectand similar functions, in cases where Python may take more than a couple seconds to connect.See https://issues.apache.org/jira/browse/SPARK-21551
How was this patch tested?
Ran the tests.
cc @rxin