Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][DOC]Replace numTasks with numPartitions in programming guide #18774

Conversation

polarker
Copy link
Contributor

In programming guide, numTasks is used in several places as arguments of Transformations. However, in code, numPartitions is used. In this fix, I replace numTasks with numPartitions in programming guide for consistency.

@remisharoon
Copy link

@polarke , can you please provide the details of how you tested this?
please provide screenshots of the locally tested doc site

@remisharoon
Copy link

remisharoon commented Jul 30, 2017

@polarke :
please refer to this Pull Request 18770 for best practices

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remisharoon in this case I don't think a screenshot is needed. The nature of the change is clear from the diff. I think the change is OK.

@SparkQA
Copy link

SparkQA commented Jul 30, 2017

Test build #3862 has finished for PR 18774 at commit ec11300.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked and it looks okay to me too.

@srowen
Copy link
Member

srowen commented Jul 30, 2017

Merged to master

@asfgit asfgit closed this in 6830e90 Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants