[SPARKR][SPARK-22344] Set java.io.tmpdir for SparkR tests #19589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also disable the hsperfdata for the JVM for CRAN checks
|
cc @felixcheung -- It'll be great if you could independently test this as well ! |
|
Test build #83132 has finished for PR 19589 at commit
|
|
it looked like maybe appveyor is running too long and timed out? |
felixcheung
reviewed
Oct 28, 2017
| @@ -18,7 +18,11 @@ | |||
| context("basic tests for CRAN") | |||
|
|
|||
| test_that("create DataFrame from list or data.frame", { | |||
| sparkR.session(master = sparkRTestMaster, enableHiveSupport = FALSE) | |||
| r_tmp_dir <- tempdir() | |||
| tmp_arg <- paste("-Djava.io.tmpdir=", r_tmp_dir, sep = "") | |||
R/pkg/tests/run-all.R
Outdated
| } else { | ||
| # Disable hsperfdata on CRAN | ||
| old_java_opt <- Sys.getenv("_JAVA_OPTIONS") | ||
| Sys.setenv("_JAVA_OPTIONS"=paste("-XX:-UsePerfData", old_java_opt, sep=" ")) |
There was a problem hiding this comment.
I think perhaps it'd better to set spark.driver.extraJavaOptions and spark.executor.extraJavaOptions (use a variable to store its value, as in sparkRTestMaster, or like in vignettes, sparkSessionConfig)
btw, I think the convention is camelCase variables :)
There was a problem hiding this comment.
also sep=" " is the default
There was a problem hiding this comment.
space between variable/value
"_JAVA_OPTIONS" = paste("-XX:-UsePerfData", old_java_opt, sep = " "
we should have a lintr rule that detects this at one point..
| @@ -57,7 +63,7 @@ We use default settings in which it runs in local mode. It auto downloads Spark | |||
|
|
|||
| ```{r, include=FALSE} | |||
| install.spark() | |||
| sparkR.session(master = "local[1]") | |||
| sparkR.session(master = "local[1]", sparkConfig = sparkSessionConfig, enableHiveSupport = FALSE) | |||
There was a problem hiding this comment.
hmm, good catch on enableHiveSupport I think this should be fine
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
| sparkSessionConfig <- list(spark.driver.extraJavaOptions = tmp_arg, | ||
| spark.executor.extraJavaOptions = tmp_arg) | ||
| old_java_opt <- Sys.getenv("_JAVA_OPTIONS") | ||
| new_java_opt <- Sys.setenv("_JAVA_OPTIONS"=paste("-XX:-UsePerfData", old_java_opt, sep = " ")) |
|
Test build #83177 has finished for PR 19589 at commit
|
felixcheung
approved these changes
Oct 29, 2017
|
Merging to master, branch-2.2 and branch-2.1 |
asfgit
pushed a commit
that referenced
this pull request
Oct 30, 2017
This PR sets the java.io.tmpdir for CRAN checks and also disables the hsperfdata for the JVM when running CRAN checks. Together this prevents files from being left behind in `/tmp` ## How was this patch tested? Tested manually on a clean EC2 machine Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu> Closes #19589 from shivaram/sparkr-tmpdir-clean. (cherry picked from commit 1fe2761) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
asfgit
pushed a commit
that referenced
this pull request
Oct 30, 2017
This PR sets the java.io.tmpdir for CRAN checks and also disables the hsperfdata for the JVM when running CRAN checks. Together this prevents files from being left behind in `/tmp` Tested manually on a clean EC2 machine Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu> Closes #19589 from shivaram/sparkr-tmpdir-clean. (cherry picked from commit 1fe2761) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
This PR sets the java.io.tmpdir for CRAN checks and also disables the hsperfdata for the JVM when running CRAN checks. Together this prevents files from being left behind in `/tmp` ## How was this patch tested? Tested manually on a clean EC2 machine Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu> Closes apache#19589 from shivaram/sparkr-tmpdir-clean. (cherry picked from commit 1fe2761) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the java.io.tmpdir for CRAN checks and also disables the hsperfdata for the JVM when running CRAN checks. Together this prevents files from being left behind in
/tmpHow was this patch tested?
Tested manually on a clean EC2 machine