[SPARK-22291][SQL] Conversion error when transforming array types of uuid, inet and cidr to StingType in PostgreSQL #19604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types of uuid, inet and cidr to StingType in PostgreSQL
|
cc @cloud-fan, the PR for 2.2, thanks! |
viirya
reviewed
Oct 30, 2017
| @@ -440,8 +440,9 @@ object JdbcUtils extends Logging { | |||
|
|
|||
| case StringType => | |||
| (array: Object) => | |||
| array.asInstanceOf[Array[java.lang.String]] | |||
| .map(UTF8String.fromString) | |||
| // some underling types are not String such as uuid, inet, cidr, etc. | |||
There was a problem hiding this comment.
Oops, a typo occurred, thanks @viirya !!
|
I found in this branch the Docker-based integration test suites will fail due to it can not pull the image |
|
Ah, let's remove |
jmchung
changed the title
jmchung
changed the title
|
Test build #83200 has finished for PR 19604 at commit
|
|
Test build #83201 has finished for PR 19604 at commit
|
|
LGTM |
|
thanks, merging to 2.2! |
asfgit
pushed a commit
that referenced
this pull request
Oct 30, 2017
…uuid, inet and cidr to StingType in PostgreSQL ## What changes were proposed in this pull request? This PR fixes the conversion error when transforming array types of `uuid`, `inet` and `cidr` to `StingType` in PostgreSQL. ## How was this patch tested? Added test in `PostgresIntegrationSuite`. Author: Jen-Ming Chung <jenmingisme@gmail.com> Closes #19604 from jmchung/SPARK-22291-FOLLOWUP.
|
can you close it? PR merged to non-master branch will not be closed automatically. thanks |
|
Sure, I'll close it and thank you and @viirya. |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…uuid, inet and cidr to StingType in PostgreSQL ## What changes were proposed in this pull request? This PR fixes the conversion error when transforming array types of `uuid`, `inet` and `cidr` to `StingType` in PostgreSQL. ## How was this patch tested? Added test in `PostgresIntegrationSuite`. Author: Jen-Ming Chung <jenmingisme@gmail.com> Closes apache#19604 from jmchung/SPARK-22291-FOLLOWUP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the conversion error when transforming array types of
uuid,inetandcidrtoStingTypein PostgreSQL.How was this patch tested?
Added test in
PostgresIntegrationSuite.