[SPARK-19611][SQL][followup] set dataSchema correctly in HiveMetastoreCatalog.convertToLogicalRelation #19615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #83234 has finished for PR 19615 at commit
|
|
also cc @dongjoon-hyun @viirya |
|
LGTM |
viirya
reviewed
Oct 31, 2017
| @@ -164,13 +164,12 @@ private[hive] class HiveMetastoreCatalog(sparkSession: SparkSession) extends Log | |||
| } | |||
| } | |||
|
|
|||
| val (dataSchema, updatedTable) = | |||
| inferIfNeeded(relation, options, fileFormat, Option(fileIndex)) | |||
| val updatedTable = inferIfNeeded(relation, options, fileFormat, Option(fileIndex)) | |||
There was a problem hiding this comment.
Yeah, we missed this. Actually the variable name is indicating it is data schema...
asfgit
pushed a commit
that referenced
this pull request
Oct 31, 2017
…eCatalog.convertToLogicalRelation We made a mistake in #16944 . In `HiveMetastoreCatalog#inferIfNeeded` we infer the data schema, merge with full schema, and return the new full schema. At caller side we treat the full schema as data schema and set it to `HadoopFsRelation`. This doesn't cause any problem because both parquet and orc can work with a wrong data schema that has extra columns, but it's better to fix this mistake. N/A Author: Wenchen Fan <wenchen@databricks.com> Closes #19615 from cloud-fan/infer. (cherry picked from commit 4d9ebf3) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
thanks, merging to master/2.2! |
|
Thank you so much, @cloud-fan ! |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…eCatalog.convertToLogicalRelation We made a mistake in apache#16944 . In `HiveMetastoreCatalog#inferIfNeeded` we infer the data schema, merge with full schema, and return the new full schema. At caller side we treat the full schema as data schema and set it to `HadoopFsRelation`. This doesn't cause any problem because both parquet and orc can work with a wrong data schema that has extra columns, but it's better to fix this mistake. N/A Author: Wenchen Fan <wenchen@databricks.com> Closes apache#19615 from cloud-fan/infer. (cherry picked from commit 4d9ebf3) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We made a mistake in #16944 . In
HiveMetastoreCatalog#inferIfNeededwe infer the data schema, merge with full schema, and return the new full schema. At caller side we treat the full schema as data schema and set it toHadoopFsRelation.This doesn't cause any problem because both parquet and orc can work with a wrong data schema that has extra columns, but it's better to fix this mistake.
How was this patch tested?
N/A