[SPARKR][SPARK-22315] Warn if SparkR package version doesn't match SparkContext #19624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaram
changed the title
|
Test build #83276 has finished for PR 19624 at commit
|
felixcheung
approved these changes
Nov 1, 2017
R/pkg/R/sparkR.R
Outdated
|
|
||
| if (jvmVersion != rPackageVersion) { | ||
| warning(paste("Version mismatch between Spark JVM and SparkR package. JVM version was", | ||
| jvmVersion, ", while R package version was", rPackageVersion)) |
There was a problem hiding this comment.
not sure if it's important, perhaps print the original version (ie. with -SNAPSHOT)
There was a problem hiding this comment.
I wonder if that would be more confusing as somebody might think they just need to remove the -snapshot ?
|
Maybe but it will say
`Version mismatch between Spark JVM and SparkR package. JVM version was 2.3.0-SNAPSHOT, while R package version was 2.1.2`
I think it will be clear the numbers are different.
If they are both 2.3.0 it won't show the warning.
|
1 similar comment
|
Maybe but it will say
I think it will be clear the numbers are different. |
|
Test build #83467 has finished for PR 19624 at commit
|
felixcheung
approved these changes
Nov 6, 2017
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2017
…arkContext ## What changes were proposed in this pull request? This PR adds a check between the R package version used and the version reported by SparkContext running in the JVM. The goal here is to warn users when they have a R package downloaded from CRAN and are using that to connect to an existing Spark cluster. This is raised as a warning rather than an error as users might want to use patch versions interchangeably (e.g., 2.1.3 with 2.1.2 etc.) ## How was this patch tested? Manually by changing the `DESCRIPTION` file Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu> Closes #19624 from shivaram/sparkr-version-check. (cherry picked from commit 65a8bf6) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…arkContext ## What changes were proposed in this pull request? This PR adds a check between the R package version used and the version reported by SparkContext running in the JVM. The goal here is to warn users when they have a R package downloaded from CRAN and are using that to connect to an existing Spark cluster. This is raised as a warning rather than an error as users might want to use patch versions interchangeably (e.g., 2.1.3 with 2.1.2 etc.) ## How was this patch tested? Manually by changing the `DESCRIPTION` file Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu> Closes apache#19624 from shivaram/sparkr-version-check. (cherry picked from commit 65a8bf6) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a check between the R package version used and the version reported by SparkContext running in the JVM. The goal here is to warn users when they have a R package downloaded from CRAN and are using that to connect to an existing Spark cluster.
This is raised as a warning rather than an error as users might want to use patch versions interchangeably (e.g., 2.1.3 with 2.1.2 etc.)
How was this patch tested?
Manually by changing the
DESCRIPTIONfile